From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Stephen J. Turnbull" Newsgroups: gmane.emacs.devel Subject: Re: New function `emacs-version>=' Date: Sun, 04 May 2003 01:08:46 +0900 Organization: The XEmacs Project Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <873cjwrp0x.fsf@tleepslib.sk.tsukuba.ac.jp> References: <20030502232146.C2FF.LEKTU@terra.es> <200305031112.h43BC9tL013684@beta.mvs.co.il> <20030503154455.C412.LEKTU@terra.es> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1051978600 14465 80.91.224.249 (3 May 2003 16:16:40 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sat, 3 May 2003 16:16:40 +0000 (UTC) Cc: monnier+gnu/emacs@rum.cs.yale.edu Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sat May 03 18:16:38 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19Bzgj-0003l3-00 for ; Sat, 03 May 2003 18:16:37 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19Bziq-00020T-00 for ; Sat, 03 May 2003 18:18:48 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 19Bzf6-0005k9-0A for emacs-devel@quimby.gnus.org; Sat, 03 May 2003 12:14:56 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 19Bzei-0005gr-00 for emacs-devel@gnu.org; Sat, 03 May 2003 12:14:32 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 19BzeO-0005BN-00 for emacs-devel@gnu.org; Sat, 03 May 2003 12:14:16 -0400 Original-Received: from tleepslib.sk.tsukuba.ac.jp ([130.158.98.109]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 19BzaL-0003Qp-00 for emacs-devel@gnu.org; Sat, 03 May 2003 12:10:02 -0400 Original-Received: from steve by tleepslib.sk.tsukuba.ac.jp with local (Exim 3.36 #1 (Debian)) id 19BzZ8-0004RY-00; Sun, 04 May 2003 01:08:46 +0900 Original-To: Juanma Barranquero In-Reply-To: <20030503154455.C412.LEKTU@terra.es> (Juanma Barranquero's message of "Sat, 03 May 2003 15:54:05 +0200") User-Agent: Gnus/5.090016 (Oort Gnus v0.16) XEmacs/21.5 (cabbage) Original-cc: ehud@unix.mvs.co.il Original-cc: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:13654 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:13654 >>>>> "Juanma" == Juanma Barranquero writes: Juanma> Yeah, well, that's perhaps the reason I wrote "you can Juanma> *often* do..." :-) Juanma> But, honestly, how many cases like this one have you Juanma> found? Isn't one enough? :-) The XEmacs Review practice wrt to emacs-version>= is to query the patch author if a feature test couldn't be used instead. About half the time in my experience the author makes a reasonable case (eg, if a package depends on multiple features that all came available with a certain version). I like Stefan's idea though; I think I'm going to implement it. It should sufficiently annoy people that they'll book up on Ben's new suite of warning control APIs, too. :-) -- Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN Ask not how you can "do" free software business; ask what your business can "do for" free software.