(perl-mode) bad indentation if no trailing comma in nested hashes

(perl-mode) bad indentation if no trailing comma in nested hashes

[Jérôme Marant]

Hi,

Could you please followup every bug report once they are fixed in order
for me to tag them as fixed. TIA.

Cheers,

----------

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=47675


>From unknown Mon Mar 07 20:56:38 2005
Received: (at submit) by bugs.debian.org; 17 Oct 1999 21:37:18 +0000
Received: (qmail 23406 invoked from network); 17 Oct 1999 21:37:13 -0000
Received: from front7m.grolier.fr (195.36.216.57)
  by master.debian.org with SMTP; 17 Oct 1999 21:37:13 -0000
Received: from bylbo.nowhere.earth (ppp-113-196.villette.club-internet.fr [194.158.113.196])
	by front7m.grolier.fr (8.9.3/No_Relay+No_Spam_MGC990224) with ESMTP id XAA27005;
	Sun, 17 Oct 1999 23:35:29 +0200 (MET DST)
Received: from dwitch by bylbo.nowhere.earth with local (Exim 3.03 #1 (Debian))
	id 11cwDj-00085y-00; Sun, 17 Oct 1999 21:43:55 +0200
From: Yann Dirson <ydirson@multimania.com>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: perl-mode: bad indentation if no trailing comma in nested hashes
X-Reportbug-Version: 0.34
X-Mailer: reportbug 0.34
Date: Sun, 17 Oct 1999 21:43:54 +0200
Message-Id: <E11cwDj-00085y-00@bylbo.nowhere.earth>

Package: emacs20
Version: 20.3-11
Severity: normal

I have a hash starting with the following lines:

%LCDkmaps = (
	     'i386' => {
		 'qwerty' => {
		     'US' => { 
			 'Standard' => 'us',
			 'With latin1' => 'us-latin1',
			 },
		     'UK' => 'uk',
		 },
	     },
	     'sparc' => {
		 'T5' => {

If I omit the trailing comma after 'us-latin1', then the 'UK' lines
erroneously gets extra indentation.

Note this is not systematic: if I omit the one following value for
'qwerty', then the 'sparc' lines still gets correct indentation.

-- System Information
Debian Release: potato
Architecture: i386
Kernel: Linux bylbo 2.2.12 #1 Sun Sep 12 22:27:06 CEST 1999 i586

Versions of packages emacs20 depends on:
ii  emacsen-common                1.4.9      Common facilities for all emacsen.
ii  libc6                         2.1.2-5    GNU C Library: Shared libraries an
ii  liblockfile1                  1.01       Shared library with NFS-safe locki
ii  libncurses4                   4.2-3.4    Shared libraries for terminal hand
ii  xlib6g                        3.3.5-1    shared libraries required by X cli

>From rlb@defaultvalue.org Tue Jul 20 20:11:45 2004
Received: (at 47675-forwarded) by bugs.debian.org; 21 Jul 2004 03:11:45 +0000
Return-path: <rlb@defaultvalue.org>
Received: from dsl093-216-237.aus1.dsl.speakeasy.net (defaultvalue.org) [66.93.216.237] (postfix)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1Bn7WC-0003XM-00; Tue, 20 Jul 2004 20:11:45 -0700
Received: from trouble.defaultvalue.org (omen.defaultvalue.org [192.168.1.1])
	by defaultvalue.org (Postfix) with ESMTP id 7984740BB;
	Tue, 20 Jul 2004 22:11:42 -0500 (CDT)
Received: by trouble.defaultvalue.org (Postfix, from userid 1000)
	id DBC0F410AC; Tue, 20 Jul 2004 22:10:39 -0500 (CDT)
To: bug-gnu-emacs@gnu.org
Cc: 47675-forwarded@bugs.debian.org
Subject: Possible old perl-mode hash indentation bug.
From: Rob Browning <rlb@defaultvalue.org>
Date: Tue, 20 Jul 2004 22:10:39 -0500
Message-ID: <87iscikqc0.fsf@trouble.defaultvalue.org>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Delivered-To: 47675-forwarded@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no 
	version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 


This bug, presuming it is a bug, has been around since at least Emacs
version 20.3.  

Given a hash like this one when in perl-mode:

  %LCDkmaps = (
               'i386' => {
                   'qwerty' => {
                       'US' => { 
                           'Standard' => 'us',
                           'With latin1' => 'us-latin1',
                           },
                       'UK' => 'uk',
                   },
               },
               'sparc' => {
                   'T5' => {

Emacs will over-indent the 'UK' line if you leave out the comma after
'us-latin1'.  (Although Emacs won't over-indent if you leave out the
comma after the 'qwerty' block'.)  Presuming I didn't make any
mistakes, this appears to be repeatable in the current version of
Emacs 21, and in CVS as of Sunday.

(If you can, please maintain the cc to the bug tracker in any followup
messages.  Thanks)

----------

-- 
Jérôme Marant

Re: (perl-mode) bad indentation if no trailing comma in nested hashes

[Stefan Monnier]

> I have a hash starting with the following lines:

> %LCDkmaps = (
> 	     'i386' => {
> 		 'qwerty' => {
> 		     'US' => { 
> 			 'Standard' => 'us',
> 			 'With latin1' => 'us-latin1',
> 			 },
> 		     'UK' => 'uk',
> 		 },
> 	     },
> 	     'sparc' => {
> 		 'T5' => {

I believe the patch I installed fixes this bug without hopefully
introducing another.


        Stefan

Re: (perl-mode) bad indentation if no trailing comma in nested hashes

[Jérôme Marant]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> I believe the patch I installed fixes this bug without hopefully
> introducing another.

Thanks. I will test ASAP.

-- 
Jérôme Marant