From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: defvars at compile time Date: Tue, 21 Mar 2006 21:20:20 -0500 Message-ID: <873bhbcjfj.fsf-monnier+emacs@gnu.org> References: <20403.1141690692@olgas.newt.com> <3861.1142268982@olgas.newt.com> <22907.1142318606@olgas.newt.com> <3669.1142364565@olgas.newt.com> <7035.1142372131@olgas.newt.com> <28215.1142437339@olgas.newt.com> <87fyldk4tx.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1143492350 7516 80.91.229.2 (27 Mar 2006 20:45:50 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 27 Mar 2006 20:45:50 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 27 22:45:48 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FNyad-0004a8-Sn for ged-emacs-devel@m.gmane.org; Mon, 27 Mar 2006 22:45:28 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FNyab-0007V5-Ss for ged-emacs-devel@m.gmane.org; Mon, 27 Mar 2006 15:45:26 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FLsxf-0000Ie-GK for emacs-devel@gnu.org; Tue, 21 Mar 2006 21:20:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FLsxe-0000Ho-2G for emacs-devel@gnu.org; Tue, 21 Mar 2006 21:20:34 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FLsxd-0000Hd-JB for emacs-devel@gnu.org; Tue, 21 Mar 2006 21:20:33 -0500 Original-Received: from [209.226.175.184] (helo=tomts22-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FLsxi-0002dQ-0j for emacs-devel@gnu.org; Tue, 21 Mar 2006 21:20:38 -0500 Original-Received: from alfajor ([70.55.140.81]) by tomts22-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20060322022020.VJZF10262.tomts22-srv.bellnexxia.net@alfajor>; Tue, 21 Mar 2006 21:20:20 -0500 Original-Received: by alfajor (Postfix, from userid 1000) id 240C1D73BE; Tue, 21 Mar 2006 21:20:20 -0500 (EST) Original-To: Katsumi Yamaoka In-Reply-To: (Katsumi Yamaoka's message of "Wed, 22 Mar 2006 10:59:43 +0900") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:52115 Archived-At: >> Emacs-21 should complain indeed, but Emacs-CVS >> shouldn't (because it recognizes the (if (boundp ..) ..) form). > Yes it is. But Gnus CVS supports Emacs 21 and XEmacs, so we > have to do something to avoid a compile warning. Well, I'd have to strongly disagree with "have to". Nothing forces you to remove all compilation warnings for all supported emacsen. >> I.e. it's a bad solution. > I think the reason it is bad is only that it might take more > time than directly referring the value of the variable. It's much worse than that. It's fundamentally wrong to make code less readable for the sake of compiler warnings. Compiler warnings are there to help you find bad code and improve it. Not to make code uglier and harder to maintain. The primacy should be with the code, not with the compiler warnings. Stefan