From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: defvars at compile time
Date: Tue, 21 Mar 2006 21:20:20 -0500 [thread overview]
Message-ID: <873bhbcjfj.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <b4m3bhbi6i8.fsf@jpl.org> (Katsumi Yamaoka's message of "Wed, 22 Mar 2006 10:59:43 +0900")
>> Emacs-21 should complain indeed, but Emacs-CVS
>> shouldn't (because it recognizes the (if (boundp ..) ..) form).
> Yes it is. But Gnus CVS supports Emacs 21 and XEmacs, so we
> have to do something to avoid a compile warning.
Well, I'd have to strongly disagree with "have to". Nothing forces you to
remove all compilation warnings for all supported emacsen.
>> I.e. it's a bad solution.
> I think the reason it is bad is only that it might take more
> time than directly referring the value of the variable.
It's much worse than that. It's fundamentally wrong to make code less
readable for the sake of compiler warnings. Compiler warnings are there to
help you find bad code and improve it. Not to make code uglier and harder
to maintain. The primacy should be with the code, not with the
compiler warnings.
Stefan
next prev parent reply other threads:[~2006-03-22 2:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-07 0:18 New GNOME icons Bill Wohler
2006-03-10 23:15 ` Bill Wohler
2006-03-10 23:56 ` Reiner Steib
2006-03-11 1:23 ` Bill Wohler
2006-03-11 1:29 ` Miles Bader
2006-03-11 12:48 ` Reiner Steib
2006-03-11 23:47 ` Miles Bader
2006-03-12 0:38 ` Bill Wohler
2006-03-13 11:52 ` Katsumi Yamaoka
[not found] ` <3861.1142268982@olgas.newt.com>
[not found] ` <b4mr755zj4i.fsf@jpl.org>
[not found] ` <22907.1142318606@olgas.newt.com>
[not found] ` <stewtext5sn.fsf@marauder.physik.uni-ulm.de>
[not found] ` <3669.1142364565@olgas.newt.com>
[not found] ` <v9y7zcrbc1.fsf@marauder.physik.uni-ulm.de>
[not found] ` <7035.1142372131@olgas.newt.com>
[not found] ` <v93bhjrjrd.fsf@marauder.physik.uni-ulm.de>
[not found] ` <28215.1142437339@olgas.newt.com>
[not found] ` <v9irqf1x1t.fsf_-_@marauder.physik.uni-ulm.de>
2006-03-15 22:52 ` defvars at compile time Katsumi Yamaoka
2006-03-16 18:31 ` Kevin Rodgers
2006-03-16 22:27 ` Johan Bockgård
2006-03-16 22:51 ` Bill Wohler
2006-03-17 2:44 ` Miles Bader
2006-03-17 16:32 ` Richard Stallman
2006-03-20 6:31 ` Stefan Monnier
2006-03-22 1:59 ` Katsumi Yamaoka
2006-03-22 2:20 ` Stefan Monnier [this message]
2006-03-28 1:41 ` Bill Wohler
2006-03-28 19:20 ` Stefan Monnier
2006-03-29 23:01 ` Richard Stallman
2006-03-28 19:33 ` Richard Stallman
-- strict thread matches above, loose matches on Subject: below --
2005-09-16 10:48 Juanma Barranquero
2005-09-16 11:18 ` David Kastrup
2005-09-16 13:25 ` Juanma Barranquero
2005-09-16 14:59 ` David Kastrup
2005-09-16 15:48 ` Stefan Monnier
2005-09-16 15:51 ` Juanma Barranquero
2005-09-17 4:57 ` Richard M. Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873bhbcjfj.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.