From: Miles Bader <miles@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Diane Murray <disumu@x3y2z1.net>, emacs-devel@gnu.org
Subject: Re: Fix previous-button to work with connected buttons
Date: Sun, 11 Mar 2007 11:45:12 +0900 [thread overview]
Message-ID: <873b4c7b2f.fsf@catnip.gol.com> (raw)
In-Reply-To: <jwvbqj0h708.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat\, 10 Mar 2007 21\:08\:51 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Neither `previous-button' nor `next-button' work well with neighboring
>> buttons inserted with `insert-text-button' - this patch is *not* able
>> to solve that problem.
>
> I think the patch below should provide a general fix.
Please don't do that -- one of the goals of buttons is to work
reasonably well if there are _lots_ of them, and that was the main
reason for supporting both "overlay" and "text" buttons. If you have
lots of buttons, creating a unique marker for each button has nasty
results (I've tested it).
[If adjacent buttons are important, I'd rather do something that only
affects that case. For instance, I suppose a hacky approach might be to
have two different button properties, like `button' and `button2', and
use `button2' if inserting just before another button that uses
`button']
Thanks,
-Miles
--
Saa, shall we dance? (from a dance-class advertisement)
next prev parent reply other threads:[~2007-03-11 2:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-10 23:53 Fix previous-button to work with connected buttons Diane Murray
2007-03-11 2:08 ` Stefan Monnier
2007-03-11 2:45 ` Miles Bader [this message]
2007-03-11 6:00 ` Stefan Monnier
2007-03-11 6:12 ` Miles Bader
2007-03-11 10:55 ` David Kastrup
2007-03-11 12:53 ` Miles Bader
2007-03-11 13:04 ` David Kastrup
2007-03-11 21:46 ` Stefan Monnier
2007-03-11 22:52 ` Miles Bader
2007-04-01 2:28 ` Diane Murray
2007-04-01 14:00 ` Richard Stallman
2007-04-01 17:15 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873b4c7b2f.fsf@catnip.gol.com \
--to=miles@gnu.org \
--cc=disumu@x3y2z1.net \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.