From: Bastien <bzg@altern.org>
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: Handle empty regexp in `rmail-nonignored-headers'
Date: Mon, 11 Feb 2008 01:01:14 +0000 [thread overview]
Message-ID: <873as0qpb9.fsf@bzg.ath.cx> (raw)
In-Reply-To: <E1JOMMb-0001iA-MV@fencepost.gnu.org> (Richard Stallman's message of "Sun, 10 Feb 2008 19:17:37 -0500")
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
Richard Stallman <rms@gnu.org> writes:
> This simple patch fixed this -- can I commit it?
>
> The patch looks correct.
Following Stefan's advice, I applied this patch instead:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: rmail.el.patch --]
[-- Type: text/x-diff, Size: 1362 bytes --]
diff -u /home/guerry/install/cvs/emacs/lisp/mail/rmail.el.\~1.447.\~ /home/guerry/install/cvs/emacs/lisp/mail/rmail.el
--- /home/guerry/install/cvs/emacs/lisp/mail/rmail.el.~1.447.~ 2008-02-01 16:01:27.000000000 +0000
+++ /home/guerry/install/cvs/emacs/lisp/mail/rmail.el 2008-02-10 21:13:03.000000000 +0000
@@ -299,6 +299,7 @@
"*Regexp to match X header fields that Rmail should show.
This regexp overrides `rmail-ignored-headers'; if both this regexp
and that one match a certain header field, Rmail shows the field.
+If this is nil, ignore all header fields in `rmail-ignored-headers'.
This variable is used for reformatting the message header,
which normally happens once for each message,
@@ -306,7 +307,7 @@
To make a change in this variable take effect
for a message that you have already viewed,
go to that message and type \\[rmail-toggle-header] twice."
- :type 'regexp
+ :type '(choice (const nil) (regexp))
:group 'rmail-headers)
;;;###autoload
@@ -2329,7 +2330,8 @@
(while (and ignored-headers
(re-search-forward ignored-headers nil t))
(beginning-of-line)
- (if (looking-at rmail-nonignored-headers)
+ (if (and rmail-nonignored-headers
+ (looking-at rmail-nonignored-headers))
(forward-line 1)
(delete-region (point)
(save-excursion
Diff finished. Mon Feb 11 01:00:01 2008
[-- Attachment #3: Type: text/plain, Size: 13 bytes --]
--
Bastien
prev parent reply other threads:[~2008-02-11 1:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-10 16:37 Handle empty regexp in `rmail-nonignored-headers' Bastien Guerry
2008-02-10 19:34 ` Stefan Monnier
2008-02-10 22:25 ` Bastien
2008-02-10 20:03 ` Eli Zaretskii
2008-02-11 0:17 ` Richard Stallman
2008-02-11 1:01 ` Bastien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873as0qpb9.fsf@bzg.ath.cx \
--to=bzg@altern.org \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.