Re: makefile filling indented comment

Re: makefile filling indented comment

[Kevin Ryde]

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

(I raised this on emacs-pretest a while back, Richard asked to wait
until after 22.1.)

In a makefile like below, with point at the start of the second line,
it'd be nice if M-q would fill the indented comment lines.  I get some
joy from the change below (or maybe \s- instead of only space and tab).

(Indented comments are run as shell commands, so I'm not certain you'd
want to do it if maximum portability was a concern, but getting bits
like this echoed can be good as a kind of printing comment.)


2008-04-07  Kevin Ryde  <user42@zip.com.au>

	* progmodes/make-mode.el (makefile-fill-paragraph): Let indented "#"
	comments go through to normal filling, not just those at the start of
	a line.


[-- Attachment #2: makefile --]
[-- Type: application/octet-stream, Size: 135 bytes --]

foo:
	# this is an indented comment, which means it will echo when run, which emacs could
	# helpfully fill with M-q
	echo "blah blah"

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: make-mode.el.indent-comment-fill.diff --]
[-- Type: text/x-diff, Size: 515 bytes --]

*** make-mode.el	27 Mar 2008 11:51:56 +1100	1.124
--- make-mode.el	07 Apr 2008 08:07:29 +1000	
***************
*** 1352,1358 ****
    (save-excursion
      (beginning-of-line)
      (cond
!      ((looking-at "^#+\\s-*")
        ;; Found a comment.  Return nil to let normal filling take place.
        nil)
  
--- 1352,1358 ----
    (save-excursion
      (beginning-of-line)
      (cond
!      ((looking-at "^[ \t]*#+\\s-*")
        ;; Found a comment.  Return nil to let normal filling take place.
        nil)