From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Emacs 22.2.90 pretest Date: Wed, 20 Aug 2008 10:44:18 -0400 Message-ID: <873akz21bx.fsf@stupidchicken.com> References: <87y72ymcig.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1219677391 2321 80.91.229.12 (25 Aug 2008 15:16:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 25 Aug 2008 15:16:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 25 17:17:21 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KXdoa-0006mc-IR for ged-emacs-devel@m.gmane.org; Mon, 25 Aug 2008 17:17:08 +0200 Original-Received: from localhost ([127.0.0.1]:52000 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KXdnb-0005L9-Fy for ged-emacs-devel@m.gmane.org; Mon, 25 Aug 2008 11:16:07 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KXdnU-0005Hb-CX for emacs-devel@gnu.org; Mon, 25 Aug 2008 11:16:00 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KXdnS-0005DI-5P for emacs-devel@gnu.org; Mon, 25 Aug 2008 11:15:59 -0400 Original-Received: from [199.232.76.173] (port=37614 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KXdnR-0005DA-W6 for emacs-devel@gnu.org; Mon, 25 Aug 2008 11:15:58 -0400 Original-Received: from [18.115.7.246] (port=36512 helo=furry) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KXdnR-0007qz-Vq for emacs-devel@gnu.org; Mon, 25 Aug 2008 11:15:58 -0400 Original-Received: by furry (Postfix, from userid 1000) id 2B5CAC05A; Wed, 20 Aug 2008 10:44:18 -0400 (EDT) In-Reply-To: (YAMAMOTO Mitsuharu's message of "Wed, 20 Aug 2008 17:10:07 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102941 Archived-At: YAMAMOTO Mitsuharu writes: > 2008-08-02 Eli Zaretskii > > * fileio.c (Fexpand_file_name): Convert the value of $HOME to a > multibyte string. > > The above change contains the same problem I pointed out in > http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-03/msg00026.html. > I.e., DECODE_FILE may GC, and pointers to Lisp String contents are not > valid after that because of relocations by compaction. How bout turning off GC in that chunk of code? *** emacs/src/fileio.c.~1.580.2.16.~ 2008-08-16 09:37:53.000000000 -0400 --- emacs/src/fileio.c 2008-08-20 10:41:49.000000000 -0400 *************** *** 1383,1390 **** --- 1383,1392 ---- tem = build_string (newdir); if (!STRING_MULTIBYTE (tem)) { + int count = inhibit_garbage_collection (); hdir = DECODE_FILE (tem); newdir = SDATA (hdir); + unbind_to (count, Qnil); } #ifdef DOS_NT collapse_newdir = 0;