From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#1052: segfault when resuming emacsclient -t in an xterm Date: Tue, 30 Sep 2008 13:06:02 -0400 Message-ID: <873ajho96t.fsf@cyd.mit.edu> Reply-To: Chong Yidong , 1052@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1222795915 28560 80.91.229.12 (30 Sep 2008 17:31:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 30 Sep 2008 17:31:55 +0000 (UTC) Cc: 1052@emacsbugs.donarmstrong.com To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 30 19:32:53 2008 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kkj5Y-0004su-NJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Sep 2008 19:32:45 +0200 Original-Received: from localhost ([127.0.0.1]:44033 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kkj4V-0003NV-Qd for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Sep 2008 13:31:39 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kkj2v-0002sP-Bp for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2008 13:30:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kkj2t-0002rd-Vb for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2008 13:30:00 -0400 Original-Received: from [199.232.76.173] (port=42633 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kkj2t-0002r8-45 for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2008 13:29:59 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:60194) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kkj2s-00034c-9K for bug-gnu-emacs@gnu.org; Tue, 30 Sep 2008 13:29:58 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8UHTt4A023178; Tue, 30 Sep 2008 10:29:56 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m8UHF3wp019482; Tue, 30 Sep 2008 10:15:03 -0700 X-Loop: don@donarmstrong.com Resent-From: Chong Yidong Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 30 Sep 2008 17:15:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1052 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1052-submit@emacsbugs.donarmstrong.com id=B1052.122279430717217 (code B ref 1052); Tue, 30 Sep 2008 17:15:03 +0000 Original-Received: (at 1052) by emacsbugs.donarmstrong.com; 30 Sep 2008 17:05:07 +0000 Original-Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8UH53iC016568 for <1052@emacsbugs.donarmstrong.com>; Tue, 30 Sep 2008 10:05:04 -0700 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 5FA3757E32A; Tue, 30 Sep 2008 13:06:02 -0400 (EDT) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 30 Sep 2008 13:30:00 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:20922 Archived-At: > The problem is that after the cited change > `xterm-remove-modify-other-keys' calls `terminal-live-p' (it was > previously using `frame-live-p') before calling > `send-string-to-terminal'. > > `terminal-live-p' does not return false when tty->output is NULL ---> > KABOOM. Looks like it's just a matter of checking tty->output, then. WDYT? *** trunk/src/dispnew.c.~1.419.~ 2008-09-28 16:09:43.000000000 -0400 --- trunk/src/dispnew.c 2008-09-30 13:02:21.000000000 -0400 *************** *** 6470,6477 **** fwrite (SDATA (string), 1, SBYTES (string), tty->termscript); fflush (tty->termscript); } ! fwrite (SDATA (string), 1, SBYTES (string), tty->output); ! fflush (tty->output); UNBLOCK_INPUT; return Qnil; } --- 6470,6480 ---- fwrite (SDATA (string), 1, SBYTES (string), tty->termscript); fflush (tty->termscript); } ! if (tty->output) ! { ! fwrite (SDATA (string), 1, SBYTES (string), tty->output); ! fflush (tty->output); ! } UNBLOCK_INPUT; return Qnil; }