all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* lisp/progmodes/tcl.el (tcl-filter): shouldn't move point
@ 2008-11-04  8:45 Ivan Shmakov
  2008-11-21 22:28 ` Stefan Monnier
  0 siblings, 1 reply; 3+ messages in thread
From: Ivan Shmakov @ 2008-11-04  8:45 UTC (permalink / raw)
  To: emacs-devel; +Cc: Ivan Shmakov

	tcl.el reads:

--cut: http://cvs.savannah.gnu.org/viewvc/*checkout*/emacs/emacs/lisp/progmodes/tcl.el?revision=1.93--
(defun tcl-filter (proc string)
  (let ((inhibit-quit t))
    (with-current-buffer (process-buffer proc)
      (goto-char (process-mark proc))
      ;; Delete prompt if requested.
      (if (marker-buffer inferior-tcl-delete-prompt-marker)
	  (progn
	    (delete-region (point) inferior-tcl-delete-prompt-marker)
	    (set-marker inferior-tcl-delete-prompt-marker nil)))))
  (comint-output-filter proc string))
--cut: http://cvs.savannah.gnu.org/viewvc/*checkout*/emacs/emacs/lisp/progmodes/tcl.el?revision=1.93--

	Thus, the point is moved every time there is a new output from
	Tcl.  Shouldn't it be like the following instead?

--- tcl.el?revision=1.93
+++ tcl.el
@@ -1031,11 +1031,11 @@
 (defun tcl-filter (proc string)
   (let ((inhibit-quit t))
     (with-current-buffer (process-buffer proc)
-      (goto-char (process-mark proc))
       ;; Delete prompt if requested.
       (if (marker-buffer inferior-tcl-delete-prompt-marker)
 	  (progn
-	    (delete-region (point) inferior-tcl-delete-prompt-marker)
+	    (delete-region (process-mark proc)
+			   inferior-tcl-delete-prompt-marker)
 	    (set-marker inferior-tcl-delete-prompt-marker nil)))))
   (comint-output-filter proc string))
 

	If such scrolling is desired, the `comint-move-point-for-output'
	variable could be set non-nil.




^ permalink raw reply	[flat|nested] 3+ messages in thread
* lisp/progmodes/tcl.el (tcl-filter): shouldn't move point
@ 2008-11-04  7:26 Ivan Shmakov
  0 siblings, 0 replies; 3+ messages in thread
From: Ivan Shmakov @ 2008-11-04  7:26 UTC (permalink / raw)
  To: emacs-devel; +Cc: Ivan Shmakov

	tcl.el reads:

--cut: http://cvs.savannah.gnu.org/viewvc/*checkout*/emacs/emacs/lisp/progmodes/tcl.el?revision=1.93--
(defun tcl-filter (proc string)
  (let ((inhibit-quit t))
    (with-current-buffer (process-buffer proc)
      (goto-char (process-mark proc))
      ;; Delete prompt if requested.
      (if (marker-buffer inferior-tcl-delete-prompt-marker)
	  (progn
	    (delete-region (point) inferior-tcl-delete-prompt-marker)
	    (set-marker inferior-tcl-delete-prompt-marker nil)))))
  (comint-output-filter proc string))
--cut: http://cvs.savannah.gnu.org/viewvc/*checkout*/emacs/emacs/lisp/progmodes/tcl.el?revision=1.93--

	Thus, the point is moved every time there is a new output from
	Tcl.  Shouldn't it be like the following instead?

--- tcl.el?revision=1.93
+++ tcl.el
@@ -1031,11 +1031,11 @@
 (defun tcl-filter (proc string)
   (let ((inhibit-quit t))
     (with-current-buffer (process-buffer proc)
-      (goto-char (process-mark proc))
       ;; Delete prompt if requested.
       (if (marker-buffer inferior-tcl-delete-prompt-marker)
 	  (progn
-	    (delete-region (point) inferior-tcl-delete-prompt-marker)
+	    (delete-region (process-mark proc)
+			   inferior-tcl-delete-prompt-marker)
 	    (set-marker inferior-tcl-delete-prompt-marker nil)))))
   (comint-output-filter proc string))
 

	If such scrolling is desired, the `comint-move-point-for-output'
	variable could be set non-nil.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-11-21 22:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-04  8:45 lisp/progmodes/tcl.el (tcl-filter): shouldn't move point Ivan Shmakov
2008-11-21 22:28 ` Stefan Monnier
  -- strict thread matches above, loose matches on Subject: below --
2008-11-04  7:26 Ivan Shmakov

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.