From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.devel Subject: lisp/progmodes/tcl.el (tcl-filter): shouldn't move point Date: Tue, 04 Nov 2008 14:45:11 +0600 Message-ID: <873ai7c220.fsf@violet.siamics.int> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1225788349 29813 80.91.229.12 (4 Nov 2008 08:45:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 4 Nov 2008 08:45:49 +0000 (UTC) Cc: Ivan Shmakov To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 04 09:46:46 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from mail-forward1.uio.no ([129.240.10.70]) by lo.gmane.org with esmtp (Exim 4.50) id 1KxHYk-0001Ur-MV for ged-emacs-devel@m.gmane.org; Tue, 04 Nov 2008 09:46:46 +0100 Original-Received: from exim by mail-out1.uio.no with local-bsmtp (Exim 4.69) (envelope-from ) id 1KxHXe-0007TD-6H for ged-emacs-devel@m.gmane.org; Tue, 04 Nov 2008 09:45:38 +0100 Original-Received: from mail-mx4.uio.no ([129.240.10.45]) by mail-out1.uio.no with esmtp (Exim 4.69) (envelope-from ) id 1KxHXe-0007T6-4x for ged-emacs-devel@m.gmane.org; Tue, 04 Nov 2008 09:45:38 +0100 Original-Received: from lists.gnu.org ([199.232.76.165]) by mail-mx4.uio.no with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1KxHXd-0003wn-Fx for ged-emacs-devel@m.gmane.org; Tue, 04 Nov 2008 09:45:38 +0100 Original-Received: from localhost ([127.0.0.1]:44459 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KxHXc-0008WQ-Cy for ged-emacs-devel@m.gmane.org; Tue, 04 Nov 2008 03:45:36 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KxHXT-0008Vm-3i for emacs-devel@gnu.org; Tue, 04 Nov 2008 03:45:27 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KxHXQ-0008VQ-Ny for emacs-devel@gnu.org; Tue, 04 Nov 2008 03:45:26 -0500 Original-Received: from [199.232.76.173] (port=35928 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KxHXQ-0008VL-Gd for emacs-devel@gnu.org; Tue, 04 Nov 2008 03:45:24 -0500 Original-Received: from mx20.gnu.org ([199.232.41.8]:54011) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KxHXQ-0006pL-BP for emacs-devel@gnu.org; Tue, 04 Nov 2008 03:45:24 -0500 Original-Received: from ey-out-1920.google.com ([74.125.78.146]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KxHXP-0005CO-7l for emacs-devel@gnu.org; Tue, 04 Nov 2008 03:45:23 -0500 Original-Received: by ey-out-1920.google.com with SMTP id 4so1051124eyg.24 for ; Tue, 04 Nov 2008 00:45:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:subject:to:cc:date :message-id:user-agent:mime-version:content-type; bh=8vGqhIi4QmNCtX25HaijKedmn7N+Jwf6apKquhgemg8=; b=wrGVbJxrwzpKV437AtrKBkYUqKM2WBoPuv3rt1S4fGYH1MuTE3jKnvX7KcaMFIwZkT 3LEBuzu4EGjzr5sqOcg+isXTR8GoztVRQo9GLsOXegfZzwn/U9NUsQerPJqOjtlIRmKN sMWnf00bnzTbS9XQmn6VyI83bllu7PevLLr0k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:subject:to:cc:date:message-id:user-agent:mime-version :content-type; b=DiQNQRT5YdhoUN7j3k8c1DkmFqB7KpcooLxb8E5lKiW7iXUiefmEarJnEb/9dyLUnM XtV7ArzrvlPbfbTeXpUyWx212Iq7qjpM5YWzOxeBnJMUnvVe9hxBTzspsjadrr6/Jn2E 9gAevY7S5NRjDMHBDPtdIDwf1h1UHlbWBOfRM= Original-Received: by 10.210.66.1 with SMTP id o1mr1293410eba.174.1225788320524; Tue, 04 Nov 2008 00:45:20 -0800 (PST) Original-Received: from violet.siamics.int ([81.201.255.124]) by mx.google.com with ESMTPS id k5sm42195333nfh.0.2008.11.04.00.45.18 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 04 Nov 2008 00:45:19 -0800 (PST) User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-UiO-SPF-Received: Received-SPF: pass (mail-mx4.uio.no: domain of gnu.org designates 199.232.76.165 as permitted sender) client-ip=199.232.76.165; envelope-from=emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org; helo=lists.gnu.org; X-UiO-Spam-info: not spam, SpamAssassin (score=-4.0, required=5.0, autolearn=disabled, MISSING_SUBJECT=0.001,NO_RECEIVED=-0.001,RCVD_IN_DNSWL_MED=-4, uiobl=NO, uiouri=NO) X-UiO-Scanned: 4AA749F0D7E41ED475C071084FA48604EF7D8B0E X-UiO-SPAM-Test: remote_host: 199.232.76.165 spam_score: -39 maxlevel 200 minaction 2 bait 0 mail/h: 18 total 75702 max/h 424 blacklist 0 greylist 0 ratelimit 0 Xref: news.gmane.org gmane.emacs.devel:105327 Archived-At: tcl.el reads: --cut: http://cvs.savannah.gnu.org/viewvc/*checkout*/emacs/emacs/lisp/progmodes/tcl.el?revision=1.93-- (defun tcl-filter (proc string) (let ((inhibit-quit t)) (with-current-buffer (process-buffer proc) (goto-char (process-mark proc)) ;; Delete prompt if requested. (if (marker-buffer inferior-tcl-delete-prompt-marker) (progn (delete-region (point) inferior-tcl-delete-prompt-marker) (set-marker inferior-tcl-delete-prompt-marker nil))))) (comint-output-filter proc string)) --cut: http://cvs.savannah.gnu.org/viewvc/*checkout*/emacs/emacs/lisp/progmodes/tcl.el?revision=1.93-- Thus, the point is moved every time there is a new output from Tcl. Shouldn't it be like the following instead? --- tcl.el?revision=1.93 +++ tcl.el @@ -1031,11 +1031,11 @@ (defun tcl-filter (proc string) (let ((inhibit-quit t)) (with-current-buffer (process-buffer proc) - (goto-char (process-mark proc)) ;; Delete prompt if requested. (if (marker-buffer inferior-tcl-delete-prompt-marker) (progn - (delete-region (point) inferior-tcl-delete-prompt-marker) + (delete-region (process-mark proc) + inferior-tcl-delete-prompt-marker) (set-marker inferior-tcl-delete-prompt-marker nil))))) (comint-output-filter proc string)) If such scrolling is desired, the `comint-move-point-for-output' variable could be set non-nil.