all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ivan Shmakov <oneingray@gmail.com>
To: emacs-devel@gnu.org
Cc: Ivan Shmakov <oneingray@gmail.com>
Subject: lisp/progmodes/tcl.el (tcl-filter): shouldn't move point
Date: Tue, 04 Nov 2008 14:45:11 +0600	[thread overview]
Message-ID: <873ai7c220.fsf@violet.siamics.int> (raw)

	tcl.el reads:

--cut: http://cvs.savannah.gnu.org/viewvc/*checkout*/emacs/emacs/lisp/progmodes/tcl.el?revision=1.93--
(defun tcl-filter (proc string)
  (let ((inhibit-quit t))
    (with-current-buffer (process-buffer proc)
      (goto-char (process-mark proc))
      ;; Delete prompt if requested.
      (if (marker-buffer inferior-tcl-delete-prompt-marker)
	  (progn
	    (delete-region (point) inferior-tcl-delete-prompt-marker)
	    (set-marker inferior-tcl-delete-prompt-marker nil)))))
  (comint-output-filter proc string))
--cut: http://cvs.savannah.gnu.org/viewvc/*checkout*/emacs/emacs/lisp/progmodes/tcl.el?revision=1.93--

	Thus, the point is moved every time there is a new output from
	Tcl.  Shouldn't it be like the following instead?

--- tcl.el?revision=1.93
+++ tcl.el
@@ -1031,11 +1031,11 @@
 (defun tcl-filter (proc string)
   (let ((inhibit-quit t))
     (with-current-buffer (process-buffer proc)
-      (goto-char (process-mark proc))
       ;; Delete prompt if requested.
       (if (marker-buffer inferior-tcl-delete-prompt-marker)
 	  (progn
-	    (delete-region (point) inferior-tcl-delete-prompt-marker)
+	    (delete-region (process-mark proc)
+			   inferior-tcl-delete-prompt-marker)
 	    (set-marker inferior-tcl-delete-prompt-marker nil)))))
   (comint-output-filter proc string))
 

	If such scrolling is desired, the `comint-move-point-for-output'
	variable could be set non-nil.




             reply	other threads:[~2008-11-04  8:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-04  8:45 Ivan Shmakov [this message]
2008-11-21 22:28 ` lisp/progmodes/tcl.el (tcl-filter): shouldn't move point Stefan Monnier
  -- strict thread matches above, loose matches on Subject: below --
2008-11-04  7:26 Ivan Shmakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873ai7c220.fsf@violet.siamics.int \
    --to=oneingray@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.