From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#1848: 23.0.60; isearch-forward fails to find colon characters in Info buffers Date: Wed, 14 Jan 2009 03:04:45 +0200 Organization: JURTA Message-ID: <873afmaeaa.fsf@jurta.org> References: <18792.57415.297530.40046@hungover.brentg.com> <87k591ibbz.fsf@jurta.org> Reply-To: Juri Linkov , 1848@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1231896226 26736 80.91.229.12 (14 Jan 2009 01:23:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 14 Jan 2009 01:23:46 +0000 (UTC) Cc: 1848@emacsbugs.donarmstrong.com, bgoodr@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 14 02:24:57 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LMuV3-000579-S1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Jan 2009 02:24:54 +0100 Original-Received: from localhost ([127.0.0.1]:51089 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LMuTn-00086Z-3K for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Jan 2009 20:23:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LMuTi-000838-4Y for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2009 20:23:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LMuTg-00082J-Rc for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2009 20:23:29 -0500 Original-Received: from [199.232.76.173] (port=54806 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LMuTg-00082A-OF for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2009 20:23:28 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:41547) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LMuTg-0000Vu-7z for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2009 20:23:28 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0E1NPE0021485; Tue, 13 Jan 2009 17:23:26 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n0E1F3H0019123; Tue, 13 Jan 2009 17:15:03 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Juri Linkov Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 14 Jan 2009 01:15:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 1848 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1848-submit@emacsbugs.donarmstrong.com id=B1848.123189523017790 (code B ref 1848); Wed, 14 Jan 2009 01:15:03 +0000 Original-Received: (at 1848) by emacsbugs.donarmstrong.com; 14 Jan 2009 01:07:10 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from relay02.kiev.sovam.com (relay02.kiev.sovam.com [62.64.120.197]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0E176Hr017784 for <1848@emacsbugs.donarmstrong.com>; Tue, 13 Jan 2009 17:07:07 -0800 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay02.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1LMuDo-0007Ao-UW; Wed, 14 Jan 2009 03:07:05 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 12 Jan 2009 14:42:35 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu) X-Scanner-Signature: e04e44772e0ad72f7751591e8aa1bd99 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Trusted X-SpamTest-Info: Profiles 5467 [Oct 22 2008] X-SpamTest-Info: {received from trusted relay: common white list} X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: white ip list X-SpamTest-Rate: 10 X-SpamTest-Status: Trusted X-SpamTest-Status-Extended: trusted X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 13 Jan 2009 20:23:29 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24089 Archived-At: >>> > I found it a bit confusing that setting search-invisible to t makes no >>> > difference to the behaviour here. Should Info-search-success-function >>> > respect search-invisible? >>> >>> I'd say yes. Does anyone object? > >> I don't object, but wouldn't it be confusing to have it "find" the >> colon, without the colon being visible? Perhaps we should make it >> temporarily visible? > > Oh, yes, definitely. If we can't temporarily show the invisible text, > then we shouldn't obey (eq search-invisible 'open), but we should still > obey (eq search-invisible t). Then the following patch does this. It checks only for (eq search-invisible t), not for 'open. BTW, I'm not sure if we should also skip the breadcrumbs line. I currently have no problems with the search matching at the breadcrumbs line. So maybe we should wait for a request from someone who has a problem with breadcrumbs. Index: lisp/info.el =================================================================== RCS file: /sources/emacs/emacs/lisp/info.el,v retrieving revision 1.557 diff -c -w -b -r1.557 info.el *** lisp/info.el 10 Jan 2009 10:42:08 -0000 1.557 --- lisp/info.el 14 Jan 2009 00:59:59 -0000 *************** *** 1868,1878 **** (let ((backward (< found beg-found))) (not (or (if backward (or (text-property-not-all found beg-found 'invisible nil) (text-property-not-all found beg-found 'display nil)) (or (text-property-not-all beg-found found 'invisible nil) ! (text-property-not-all beg-found found 'display nil))) ;; Skip node header line (and (save-excursion (forward-line -1) (looking-at "\^_")) --- 1868,1879 ---- (let ((backward (< found beg-found))) (not (or + (and (not (eq search-invisible t)) (if backward (or (text-property-not-all found beg-found 'invisible nil) (text-property-not-all found beg-found 'display nil)) (or (text-property-not-all beg-found found 'invisible nil) ! (text-property-not-all beg-found found 'display nil)))) ;; Skip node header line (and (save-excursion (forward-line -1) (looking-at "\^_")) -- Juri Linkov http://www.jurta.org/emacs/