From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 1848@emacsbugs.donarmstrong.com, bgoodr@gmail.com
Subject: bug#1848: 23.0.60; isearch-forward fails to find colon characters in Info buffers
Date: Wed, 14 Jan 2009 03:04:45 +0200 [thread overview]
Message-ID: <873afmaeaa.fsf@jurta.org> (raw)
In-Reply-To: <jwvhc442tzc.fsf-monnier+emacsbugreports@gnu.org> (Stefan Monnier's message of "Mon, 12 Jan 2009 14:42:35 -0500")
>>> > I found it a bit confusing that setting search-invisible to t makes no
>>> > difference to the behaviour here. Should Info-search-success-function
>>> > respect search-invisible?
>>>
>>> I'd say yes. Does anyone object?
>
>> I don't object, but wouldn't it be confusing to have it "find" the
>> colon, without the colon being visible? Perhaps we should make it
>> temporarily visible?
>
> Oh, yes, definitely. If we can't temporarily show the invisible text,
> then we shouldn't obey (eq search-invisible 'open), but we should still
> obey (eq search-invisible t).
Then the following patch does this. It checks only for
(eq search-invisible t), not for 'open.
BTW, I'm not sure if we should also skip the breadcrumbs line.
I currently have no problems with the search matching at the
breadcrumbs line. So maybe we should wait for a request
from someone who has a problem with breadcrumbs.
Index: lisp/info.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/info.el,v
retrieving revision 1.557
diff -c -w -b -r1.557 info.el
*** lisp/info.el 10 Jan 2009 10:42:08 -0000 1.557
--- lisp/info.el 14 Jan 2009 00:59:59 -0000
***************
*** 1868,1878 ****
(let ((backward (< found beg-found)))
(not
(or
(if backward
(or (text-property-not-all found beg-found 'invisible nil)
(text-property-not-all found beg-found 'display nil))
(or (text-property-not-all beg-found found 'invisible nil)
! (text-property-not-all beg-found found 'display nil)))
;; Skip node header line
(and (save-excursion (forward-line -1)
(looking-at "\^_"))
--- 1868,1879 ----
(let ((backward (< found beg-found)))
(not
(or
+ (and (not (eq search-invisible t))
(if backward
(or (text-property-not-all found beg-found 'invisible nil)
(text-property-not-all found beg-found 'display nil))
(or (text-property-not-all beg-found found 'invisible nil)
! (text-property-not-all beg-found found 'display nil))))
;; Skip node header line
(and (save-excursion (forward-line -1)
(looking-at "\^_"))
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2009-01-14 1:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87k58x79zl.fsf@jurta.org>
2009-01-10 17:52 ` bug#1848: 23.0.60; isearch-forward fails to find colon characters in Info buffers Brent Goodrick
2009-01-12 1:04 ` Juri Linkov
2009-01-12 8:37 ` Glenn Morris
2009-01-12 15:21 ` Stefan Monnier
2009-01-12 15:25 ` Brent Goodrick
2009-01-12 19:05 ` Eli Zaretskii
2009-01-12 19:42 ` Stefan Monnier
2009-01-14 1:04 ` Juri Linkov [this message]
2009-01-14 1:51 ` Stefan Monnier
2009-01-14 23:25 ` bug#1848: marked as done (23.0.60; isearch-forward fails to find colon characters in Info buffers) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873afmaeaa.fsf@jurta.org \
--to=juri@jurta.org \
--cc=1848@emacsbugs.donarmstrong.com \
--cc=bgoodr@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.