From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs,gmane.emacs.devel Subject: bug#1405: detached GTK+ tool bar Date: Mon, 02 Mar 2009 09:30:38 +0100 Message-ID: <873adw498x.fsf@escher.local.home> References: <87hc5zcug7.fsf@cyd.mit.edu> <492937F5.1040301__9972.48901189796$1227438707$gmane$org@swipnet.se> <87ej12m1ar.fsf@escher.local.home> <494A9B6E.6060307__43219.0094412819$1229627215$gmane$org@swipnet.se> <87tz91ky8s.fsf__3258.61482783711$1229634381$gmane$org@escher.local.home> <87d4el4r59.fsf__38436.7469735027$1232225105$gmane$org@escher.local.home> <878wnpkuku.fsf@escher.local.home> <5CDF1AA3-F4F1-4A9E-A789-C4436898E5EF__16363.0212926821$1235978742$gmane$org@swipnet.se> Reply-To: Stephen Berman , 1405@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1235983437 22245 80.91.229.12 (2 Mar 2009 08:43:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Mar 2009 08:43:57 +0000 (UTC) Cc: Chong Yidong , 1405@emacsbugs.donarmstrong.com, "emacs-devel@gnu.org" To: "Jan D." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 02 09:45:13 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Le3lu-0004RF-Uo for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Mar 2009 09:45:11 +0100 Original-Received: from localhost ([127.0.0.1]:54396 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Le3kZ-00079f-PG for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Mar 2009 03:43:47 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Le3kV-00079P-Mp for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2009 03:43:43 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Le3kT-00079D-9x for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2009 03:43:42 -0500 Original-Received: from [199.232.76.173] (port=41719 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Le3kT-00079A-4e for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2009 03:43:41 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:56706) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Le3kS-0006wh-LD for bug-gnu-emacs@gnu.org; Mon, 02 Mar 2009 03:43:40 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n228hcIa021337; Mon, 2 Mar 2009 00:43:38 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n228e4bk020312; Mon, 2 Mar 2009 00:40:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stephen Berman Original-Sender: steve@escher.local.home Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 02 Mar 2009 08:40:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 1405 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1405-submit@emacsbugs.donarmstrong.com id=B1405.123598265118895 (code B ref 1405); Mon, 02 Mar 2009 08:40:04 +0000 Original-Received: (at 1405) by emacsbugs.donarmstrong.com; 2 Mar 2009 08:30:51 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id n228UlgL018889 for <1405@emacsbugs.donarmstrong.com>; Mon, 2 Mar 2009 00:30:48 -0800 Original-Received: (qmail invoked by alias); 02 Mar 2009 08:30:41 -0000 Original-Received: from i59F5450F.versanet.de (EHLO escher.local.home) [89.245.69.15] by mail.gmx.net (mp059) with SMTP; 02 Mar 2009 09:30:41 +0100 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX1/EnjE6hHPEDphQ28QjStpjegrJRMGLe+YOYdCi4k JsscsSe3P4gqdN Original-Received: by escher.local.home (Postfix, from userid 1000) id 6C8AF1D0BAB; Mon, 2 Mar 2009 09:30:38 +0100 (CET) In-Reply-To: <5CDF1AA3-F4F1-4A9E-A789-C4436898E5EF__16363.0212926821$1235978742$gmane$org@swipnet.se> (Jan D.'s message of "Mon, 2 Mar 2009 08:01:24 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.6 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 02 Mar 2009 03:43:42 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:25907 gmane.emacs.devel:109393 Archived-At: On Mon, 2 Mar 2009 08:01:24 +0100 "Jan D." wrote: > How does this work when the button is a menu, i.e. help? > > I will be travelling for 2 weeks. I can't test it until then. > > Jan D. > > 1 mar 2009 kl. 18.43 skrev Stephen Berman : > [...] >> The patch below (against the current CVS trunk) makes focus return to >> the frame regardless of the value of x-gtk-whole-detached-tool-bar >> (i.e., it works both with the proxy (arrow) and the whole detached tool >> bar). Jan D. or somebody else who's familiar with GTK+ should check to >> make sure it does not cause any problems elsewhere. AFAICT it DTRT; i.e., when I'm in a mode in which clicking the Help button opens a menu when the tool bar is attached to the frame, the same thing happens with the detached tool bar, with both the arrow and the whole tool bar versions. This is both with and without my patch; the only difference is that with my patch, after clicking a Help menu item focus returns to the frame with both types of detached tool bar, while without my patch, focus returns only with the arrow tool bar. IOW, also in this case the patch appears to be OK. Steve Berman