From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: finalpatch Newsgroups: gmane.emacs.devel Subject: org-gnus.el returns incorrect message subject in article mode Date: Fri, 05 Jun 2009 11:19:25 +1000 Message-ID: <873aafiijm.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1244169661 19643 80.91.229.12 (5 Jun 2009 02:41:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Jun 2009 02:41:01 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 05 04:40:57 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MCPMW-0006HX-3u for ged-emacs-devel@m.gmane.org; Fri, 05 Jun 2009 04:40:56 +0200 Original-Received: from localhost ([127.0.0.1]:41921 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MCPMU-0002RZ-FB for ged-emacs-devel@m.gmane.org; Thu, 04 Jun 2009 22:40:54 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MCO63-0004BV-Rt for emacs-devel@gnu.org; Thu, 04 Jun 2009 21:19:52 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MCO5z-00049Q-7p for emacs-devel@gnu.org; Thu, 04 Jun 2009 21:19:51 -0400 Original-Received: from [199.232.76.173] (port=51722 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MCO5y-00049L-Vb for emacs-devel@gnu.org; Thu, 04 Jun 2009 21:19:47 -0400 Original-Received: from main.gmane.org ([80.91.229.2]:44820 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MCO5y-00051n-IX for emacs-devel@gnu.org; Thu, 04 Jun 2009 21:19:47 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1MCO5q-00048q-2B for emacs-devel@gnu.org; Fri, 05 Jun 2009 01:19:38 +0000 Original-Received: from 203.111.191.138 ([203.111.191.138]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 05 Jun 2009 01:19:38 +0000 Original-Received: from fengli by 203.111.191.138 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 05 Jun 2009 01:19:38 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 24 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 203.111.191.138 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (windows-nt) Cancel-Lock: sha1:sSebDOZK0NFto5GZepCSchLmNxs= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:111339 Archived-At: Hi group, I found that running org-store-link inside a gnus article buffer gives out incorrect message subject. This is because in gnus-article-mode the gnus-summary-subject-string function returns the subject of the next message instead of the current one. The following patch fixes this problem for me. --- c:\users\fengl\code\emacs\lisp\org\org-gnus.el Tue Feb 24 09:05:12 2009 +++ c:\emacs\lisp\org\org-gnus.el Fri Jun 5 11:02:31 2009 @@ -133,7 +133,9 @@ (to (mail-header 'to header)) (newsgroups (mail-header 'newsgroups header)) (x-no-archive (mail-header 'x-no-archive header)) - (subject (gnus-summary-subject-string)) + (subject (if (eq major-mode 'gnus-article-mode) + (message-fetch-field "subject") + (gnus-summary-subject-string))) desc link) (org-store-link-props :type "gnus" :from from :subject subject :message-id message-id :group group :to to) -- finalpatch