From: Kevin Ryde <user42@zip.com.au>
To: emacs-pretest-bug@gnu.org
Subject: bug#3964: 23.1.50; checkdoc more safe-local-variable
Date: Thu, 30 Jul 2009 09:05:43 +1000 [thread overview]
Message-ID: <873a8frsxk.fsf@blah.blah> (raw)
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
I noticed a couple of checkdoc.el variables which could have
safe-local-variable settings. I struck checkdoc-arguments-in-order-flag
and checkdoc-symbol-words in bongo.el.
The checkdoc-symbol-words docstring invites you to set it as a local
variable, so it in particular ought to have something for what's safe.
2009-07-30 Kevin Ryde <user42@zip.com.au>
* emacs-lisp/checkdoc.el (checkdoc-force-history-flag,
checkdoc-arguments-in-order-flag): Add safe-local-variable booleanp.
(checkdoc-symbol-words): Add safe-local-variable for list of strings,
clarify docstring that the value is strings not symbols.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: checkdoc.el.safe-lvar.diff --]
[-- Type: text/x-diff, Size: 2038 bytes --]
*** checkdoc.el 23 Jul 2009 07:41:51 +1000 1.72
--- checkdoc.el 28 Jul 2009 14:29:14 +1000
***************
*** 223,228 ****
--- 223,229 ----
This helps document the evolution of, and recent changes to, the package."
:group 'checkdoc
:type 'boolean)
+ ;;;###autoload(put 'checkdoc-force-history-flag 'safe-local-variable 'booleanp)
(defcustom checkdoc-permit-comma-termination-flag nil
"Non-nil means the first line of a docstring may end with a comma.
***************
*** 270,275 ****
--- 271,277 ----
made in the style guide relating to order."
:group 'checkdoc
:type 'boolean)
+ ;;;###autoload(put 'checkdoc-arguments-in-order-flag 'safe-local-variable 'booleanp)
(defvar checkdoc-style-hooks nil
"Hooks called after the standard style check is completed.
***************
*** 307,317 ****
with a universal argument.")
(defcustom checkdoc-symbol-words nil
! "A list of symbols which also happen to make good words.
! These symbol-words are ignored when unquoted symbols are searched for.
This should be set in an Emacs Lisp file's local variables."
:group 'checkdoc
:type '(repeat (symbol :tag "Word")))
(defvar checkdoc-proper-noun-list
'("ispell" "xemacs" "emacs" "lisp")
--- 309,327 ----
with a universal argument.")
(defcustom checkdoc-symbol-words nil
! "A list of symbol names (strings) which also happen to make good words.
! These words are ignored when unquoted symbols are searched for.
This should be set in an Emacs Lisp file's local variables."
:group 'checkdoc
:type '(repeat (symbol :tag "Word")))
+ ;;;###autoload(put 'checkdoc-symbol-words 'safe-local-variable 'checkdoc-list-of-strings-p)
+
+ ;;;###autoload
+ (defun checkdoc-list-of-strings-p (obj)
+ ;; this is a function so it might be shared by checkdoc-proper-noun-list
+ ;; and/or checkdoc-ispell-lisp-words in the future
+ (and (listp obj)
+ (not (memq nil (mapcar 'stringp obj)))))
(defvar checkdoc-proper-noun-list
'("ispell" "xemacs" "emacs" "lisp")
next reply other threads:[~2009-07-29 23:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <d38whbmoz2.fsf@fencepost.gnu.org>
2009-07-29 23:05 ` Kevin Ryde [this message]
2009-08-22 23:10 ` bug#3964: marked as done (23.1.50; checkdoc more safe-local-variable) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873a8frsxk.fsf@blah.blah \
--to=user42@zip.com.au \
--cc=3964@emacsbugs.donarmstrong.com \
--cc=emacs-pretest-bug@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.