all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Štěpán Němec" <stepnem@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Julien Danjou <julien@danjou.info>, emacs-devel@gnu.org
Subject: Misleading `window-system' docstring (was Re: Dashes in mode-line)
Date: Wed, 20 Oct 2010 15:05:02 +0200	[thread overview]
Message-ID: <8739s1qakh.fsf_-_@gmail.com> (raw)
In-Reply-To: <E1P8BwF-00065F-Ov@fencepost.gnu.org> (Eli Zaretskii's message of "Tue, 19 Oct 2010 09:09:11 -0400")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Julien Danjou <julien@danjou.info>
>> Cc: emacs-devel@gnu.org
>> Date: Tue, 19 Oct 2010 12:32:33 +0200
>> 
>> +         `(:eval (unless window-system
>> +                   ,(propertize "-%-" 'help-echo help-echo)))))
>
> Using window-system is not right here, because the DOS port defines a
> non-nil value, but uses a text terminal.

Could you please fix the docstring of `window-system' to reflect that?
It seems to be widely used that (incorrect, as you point out) way, and
its docstring is pretty clear (and thus incorrect) on the matter:

  The value is nil if the selected frame is on a text-only-terminal.

Štěpán



  parent reply	other threads:[~2010-10-20 13:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-18 13:36 Dashes in mode-line Julien Danjou
2010-10-18 14:52 ` Eli Zaretskii
2010-10-19 10:32   ` Julien Danjou
2010-10-19 13:09     ` Eli Zaretskii
2010-10-19 14:59       ` Julien Danjou
2010-10-19 19:21         ` Chong Yidong
2010-10-19 15:51       ` Jason Rumney
2010-10-19 18:30         ` Eli Zaretskii
2010-10-20 13:05       ` Štěpán Němec [this message]
2010-10-20 18:20         ` Misleading `window-system' docstring Eli Zaretskii
2010-10-20 18:32           ` Chong Yidong
2010-10-21  0:58           ` Stefan Monnier
2010-10-22 10:38             ` Eli Zaretskii
2010-10-19 12:29   ` Dashes in mode-line Deniz Dogan
2010-10-19 13:08     ` Eli Zaretskii
2010-10-19 13:49   ` Deniz Dogan
2010-10-19 14:31     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8739s1qakh.fsf_-_@gmail.com \
    --to=stepnem@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=julien@danjou.info \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.