Package menu not read-only

Package menu not read-only

[Ralf Angeli]

Hi,

the buffer with the package menu (`M-x list-packages <RET>') is not
read-only.  The problem is due to `buffer-read-only' being set to nil in
`package--generate-package-list'.  This seems to be unnecessary because
`inhibit-read-only' is temporarily set to t anyway.  So I'd suggest the
following fix which I can apply if there are no objections.

--- lisp/emacs-lisp/package.el	2010-09-22 03:31:30 +0000
+++ lisp/emacs-lisp/package.el	2010-10-24 09:50:14 +0000
@@ -1474,7 +1474,6 @@
   (package-initialize)
   (let ((inhibit-read-only t)
 	info-list name desc hold builtin)
-    (setq buffer-read-only nil)
     (erase-buffer)
     ;; List installed packages
     (dolist (elt package-alist)

I noticed the problem when typing <TAB> in the buffer in order to jump
to the next "link".  Apparently the package names are no links at all
and <TAB> does not make much sense here.  Wouldn't it be better from a
usability point of view to remove the underlining from the package
names?

In order to make it more apparent that commands in the buffer work on
whole lines and the horizontal position of point is not really relevant
one could also highlight the whole line in which point is located,
similar to what RefTeX does in table of contents (`C-c =' in a LaTeX
file).

-- 
Ralf

Re: Package menu not read-only

[Chong Yidong]

Ralf Angeli <angeli@caeruleus.net> writes:

> the buffer with the package menu (`M-x list-packages <RET>') is not
> read-only.  The problem is due to `buffer-read-only' being set to nil in
> `package--generate-package-list'.  This seems to be unnecessary because
> `inhibit-read-only' is temporarily set to t anyway.  So I'd suggest the
> following fix which I can apply if there are no objections.

Thanks, committed.

> I noticed the problem when typing <TAB> in the buffer in order to jump
> to the next "link".  Apparently the package names are no links at all
> and <TAB> does not make much sense here.

They are links, or rather buttons, and are clickable with the mouse.
I've just changed package-menu-mode-map to make button-buffer-map its
parent.  This should let TAB work.

> In order to make it more apparent that commands in the buffer work on
> whole lines and the horizontal position of point is not really
> relevant one could also highlight the whole line in which point is
> located, similar to what RefTeX does in table of contents (`C-c =' in
> a LaTeX file).

I don't think it's a good idea for non-electric modes to highlight the
whole line.  For the case of the *Packages* menu, the text color helps
to indicate each package's installation status, and it would be annoying
to have this information masked hidden for the current line.

Re: Package menu not read-only

[Ralf Angeli]

* Chong Yidong (2010-10-24) writes:

> Ralf Angeli <angeli@caeruleus.net> writes:
>
>> I noticed the problem when typing <TAB> in the buffer in order to jump
>> to the next "link".  Apparently the package names are no links at all
>> and <TAB> does not make much sense here.
>
> They are links, or rather buttons, and are clickable with the mouse.
> I've just changed package-menu-mode-map to make button-buffer-map its
> parent.  This should let TAB work.

Yup.  A much nicer experience now. (c:

-- 
Ralf