From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: bug image-dired fail with C-t i at first use. Date: Sun, 30 Jan 2011 15:22:47 +0100 Message-ID: <8739oatqrs.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1296397391 2161 80.91.229.12 (30 Jan 2011 14:23:11 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 30 Jan 2011 14:23:11 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 30 15:23:07 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PjYBG-0007oY-QG for ged-emacs-devel@m.gmane.org; Sun, 30 Jan 2011 15:23:06 +0100 Original-Received: from localhost ([127.0.0.1]:57999 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PjYBG-0001HS-60 for ged-emacs-devel@m.gmane.org; Sun, 30 Jan 2011 09:23:06 -0500 Original-Received: from [140.186.70.92] (port=60087 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PjYBC-0001HL-9r for emacs-devel@gnu.org; Sun, 30 Jan 2011 09:23:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PjYBB-0006EA-6W for emacs-devel@gnu.org; Sun, 30 Jan 2011 09:23:02 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:38774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PjYBA-0006E4-Vn for emacs-devel@gnu.org; Sun, 30 Jan 2011 09:23:01 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PjYB8-0007kd-5d for emacs-devel@gnu.org; Sun, 30 Jan 2011 15:22:58 +0100 Original-Received: from 63.211.85-79.rev.gaoland.net ([79.85.211.63]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 30 Jan 2011 15:22:58 +0100 Original-Received: from thierry.volpiatto by 63.211.85-79.rev.gaoland.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 30 Jan 2011 15:22:58 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 28 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 63.211.85-79.rev.gaoland.net User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.2.92 (gnu/linux) Cancel-Lock: sha1:Rr5rkg0INU1YQp8EIZrxIM6/NmA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135241 Archived-At: Hi, C-t i fail when using it the very first time because image-dired-dir doesn't exists yet.(C-t d only create dir). Following patch fix it, but may be other functions need this too. --- lisp/image-dired.el | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lisp/image-dired.el b/lisp/image-dired.el index 4891958..bf73a5b 100644 --- a/lisp/image-dired.el +++ b/lisp/image-dired.el @@ -1790,6 +1790,8 @@ should feel snappy enough. If optional argument ORIGINAL-SIZE is non-nil, display image in its original size." + (unless (file-directory-p image-dired-dir) + (make-directory image-dired-dir t)) (let ((new-file (expand-file-name image-dired-temp-image-file)) width height command ret (image-type 'jpeg)) -- A+ Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997