From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Newsgroups: gmane.emacs.bugs Subject: bug#8897: `completion--insert-strings' clobbers user-added text properties Date: Sun, 19 Jun 2011 20:22:54 +0200 Message-ID: <8739j5bs01.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1308508107 18868 80.91.229.12 (19 Jun 2011 18:28:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 19 Jun 2011 18:28:27 +0000 (UTC) To: 8897@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 19 20:28:23 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QYMjO-0003Ll-J9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Jun 2011 20:28:22 +0200 Original-Received: from localhost ([::1]:49660 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYMjN-00027A-SY for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Jun 2011 14:28:21 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:41281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYMj6-00026h-QP for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2011 14:28:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QYMj5-0001mF-85 for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2011 14:28:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYMj5-0001mB-1a for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2011 14:28:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QYMj4-0004TD-F9; Sun, 19 Jun 2011 14:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jun 2011 18:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8897 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs Original-Received: via spool by submit@debbugs.gnu.org id=B.130850803517125 (code B ref -1); Sun, 19 Jun 2011 18:28:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Jun 2011 18:27:15 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QYMiJ-0004SA-4t for submit@debbugs.gnu.org; Sun, 19 Jun 2011 14:27:15 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QYMiG-0004Ry-Fp for submit@debbugs.gnu.org; Sun, 19 Jun 2011 14:27:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QYMiA-0001ef-5b for submit@debbugs.gnu.org; Sun, 19 Jun 2011 14:27:07 -0400 Original-Received: from lists.gnu.org ([140.186.70.17]:54243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYMi9-0001eb-UG for submit@debbugs.gnu.org; Sun, 19 Jun 2011 14:27:06 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:41074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYMi8-0001yS-KR for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2011 14:27:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QYMi7-0001cP-2H for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2011 14:27:04 -0400 Original-Received: from mail-fx0-f52.google.com ([209.85.161.52]:32888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYMi6-0001cL-PP for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2011 14:27:02 -0400 Original-Received: by fxm6 with SMTP id 6so1640199fxm.39 for ; Sun, 19 Jun 2011 11:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:message-id:mime-version :content-type; bh=bjoY29tIR+b9qdrODb+MyzqR5MSh5JOYSdpApNXWLQ8=; b=oEGiOqSxgBN+DRg44MmqaU2hFbgY0GwXEfufhJQa35FZJP480HvCvwU5WUu/YosOV6 ISCu9geee4XdkuOh3S3iBKaJAkHi4WSf5um+UmOBsGjAVU2Al6mb/WwN9EGTxwt6nBCe nBcfDPcfvMJPfHlVQG2yVmtr7/Mspoy5tcTuM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:mime-version:content-type; b=fevg/tQv9TCKVqQoD7beXUr90E6f4PVtx6pusoRiQdmSIa8wqht8+5aLpuKzyEYiy7 1KqOBAitg/6YkUN9zagkXLmKfn34UZ8ejFu89uEMn0pL4QWlR7Eu01YZwya8YfyvzhVV R87jfsHZybW1rK8s4sr3HzwSZ2M2tkZP05Qbs= Original-Received: by 10.223.78.140 with SMTP id l12mr4924964fak.147.1308508021318; Sun, 19 Jun 2011 11:27:01 -0700 (PDT) Original-Received: from localhost (176.119.broadband10.iol.cz [90.177.119.176]) by mx.google.com with ESMTPS id r10sm2379949fah.26.2011.06.19.11.26.59 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 19 Jun 2011 11:27:00 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 19 Jun 2011 14:28:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:47319 Archived-At: Tags: patch It is possible to bind `completion-annotate-function' to add custom annotations, which is great. Unfortunately, the `face' and `mouse-face' text properties added by such a function are then unconditionally overwritten by `completion--insert-strings'. In my particular case I define annotations as buttons (which display even more detail about a completion value upon activation), so a visual indication of clickability is very important for me. I wonder if something like the patch below, which fixes the problem for me, could be applied? diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 284cbdc..11534e6 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -1003,9 +1003,12 @@ (defun completion--insert-strings (strings) 'mouse-face 'highlight) (put-text-property (point) (progn (insert (car str)) (point)) 'mouse-face 'highlight) - (add-text-properties (point) (progn (insert (cadr str)) (point)) - '(mouse-face nil - face completions-annotations))) + (let ((annotation (cadr str))) + (if (text-properties-at 1 annotation) + (insert annotation) + (add-text-properties (point) (progn (insert annotation) (point)) + '(mouse-face nil + face completions-annotations))))) (cond ((eq completions-format 'vertical) ;; Vertical format