From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] minibuffer issue with eshell-command Date: Thu, 06 Oct 2011 11:00:35 -0400 Message-ID: <8739f6magc.fsf@stupidchicken.com> References: <87lisy7g00.fsf@gmail.com> <87hb3me15c.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1317913257 22798 80.91.229.12 (6 Oct 2011 15:00:57 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 6 Oct 2011 15:00:57 +0000 (UTC) Cc: emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 06 17:00:54 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RBpRK-0006Gm-Cn for ged-emacs-devel@m.gmane.org; Thu, 06 Oct 2011 17:00:50 +0200 Original-Received: from localhost ([::1]:53004 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBpRK-0003BT-1Y for ged-emacs-devel@m.gmane.org; Thu, 06 Oct 2011 11:00:50 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:48580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBpRC-0003BN-P6 for emacs-devel@gnu.org; Thu, 06 Oct 2011 11:00:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RBpR8-0005sx-BM for emacs-devel@gnu.org; Thu, 06 Oct 2011 11:00:42 -0400 Original-Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]:40456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBpR8-0005ss-30 for emacs-devel@gnu.org; Thu, 06 Oct 2011 11:00:38 -0400 Original-Received: from furball (dhcp-128-36-14-81.central.yale.edu [128.36.14.81]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id p96F0ZUe031333 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 6 Oct 2011 11:00:36 -0400 In-Reply-To: <87hb3me15c.fsf@gmail.com> (Thierry Volpiatto's message of "Thu, 06 Oct 2011 14:48:47 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 130.132.50.144 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:144615 Archived-At: Thierry Volpiatto writes: > Thierry Volpiatto writes: > >> Hi all, >> When eshell-command start, it set eshell-mode in all minibuffers: >> ;(add-hook 'minibuffer-setup-hook 'eshell-mode) >> So when running another minibuffer, while eshell-command is started, >> it enable eshell-mode in this one, which is wrong. >> This patch fix this: > > Any objections to push this on trunk? Looks good, please go ahead.