bug#10392: mention ad-handle-definition startup warnings

bug#10392: mention ad-handle-definition startup warnings

[jidanni]

X-Debbugs-Cc: yamaoka@jpl.org

(info "(elisp) Advising Functions")
doesn't mention that e.g., putting

(defadvice gnus-summary-select-article-buffer (after jump-to-html-part
						     activate)
  "Jump to an html part that emacs-w3m rendered, if any."
  (unless (get-text-property (point) 'mm-inline-text-html-with-w3m)
    (let ((pos (text-property-any (point-min) (point-max)
				  'mm-inline-text-html-with-w3m t)))
      (gnus-goto-char pos))))

in .gnus.el will cause startup warnings

   ad-handle-definition: `gnus-summary-select-article-buffer' got redefined

for the rest of one's life, with no mention of workarounds to turn them
off either.

bug#10392: mention ad-handle-definition startup warnings

[Glenn Morris]

tags 10392 notabug
stop

jidanni@jidanni.org wrote:

> doesn't mention that e.g., putting
>
> (defadvice gnus-summary-select-article-buffer (after jump-to-html-part
> 						     activate)
>   "Jump to an html part that emacs-w3m rendered, if any."
>   (unless (get-text-property (point) 'mm-inline-text-html-with-w3m)
>     (let ((pos (text-property-any (point-min) (point-max)
> 				  'mm-inline-text-html-with-w3m t)))
>       (gnus-goto-char pos))))
>
> in .gnus.el will cause startup warnings
>
>    ad-handle-definition: `gnus-summary-select-article-buffer' got redefined

By itself, it does not.

> for the rest of one's life, with no mention of workarounds to turn them
> off either.

C-h v ad-redefinition-action


Ask on help-gnu-emacs if you need more explanation about using advice.

bug#10392: I need to turn off defadvice warnings

[jidanni]

OK,
(info "(elisp) Advising Functions")
should mention that advising functions will produce warnings.
And to turn off the warnings, one needs to (setq ad-redefinition-action 'accept),
and one cannot just turn them off for one advice, with e.g., let().

;(let ((ad-redefinition-action 'accept))
  (setq ad-redefinition-action 'accept)
  (defadvice gnus-summary-select-article-buffer (after jump-to-html-part
						     activate)
  "Jump to an html part that emacs-w3m rendered, if any."
  (unless (get-text-property (point) 'mm-inline-text-html-with-w3m)
    (let ((pos (text-property-any (point-min) (point-max)
				  'mm-inline-text-html-with-w3m t)))
      (gnus-goto-char pos))))
;)

I need to turn off defadvice warnings

[jidanni]

A friend told me to use
(defadvice gnus-summary-select-article-buffer ...

But now I get
ad-handle-definition: `gnus-summary-select-article-buffer' got redefined
warnings.

Is there anyway to turn them off?

(info "(elisp) Advising Functions")

doesn't mention the warnings!

Can I turn them off for just this one advice?

Or is the only way rewrite the whole function with defun?

Re: I need to turn off defadvice warnings

[jidanni]

OK,
(info "(elisp) Advising Functions")
should mention that advising functions will produce warnings.
And to turn off the warnings, one needs to (setq ad-redefinition-action 'accept),
and one cannot just turn them off for one advice, with e.g., let().

;(let ((ad-redefinition-action 'accept))
  (setq ad-redefinition-action 'accept)
  (defadvice gnus-summary-select-article-buffer (after jump-to-html-part
						     activate)
  "Jump to an html part that emacs-w3m rendered, if any."
  (unless (get-text-property (point) 'mm-inline-text-html-with-w3m)
    (let ((pos (text-property-any (point-min) (point-max)
				  'mm-inline-text-html-with-w3m t)))
      (gnus-goto-char pos))))
;)

Re: I need to turn off defadvice warnings

[Tassilo Horn]

jidanni@jidanni.org writes:

> A friend told me to use
> (defadvice gnus-summary-select-article-buffer ...
>
> But now I get
> ad-handle-definition: `gnus-summary-select-article-buffer' got redefined
> warnings.
>
> Is there anyway to turn them off?

Don't simply turn off a warning, but check what causes it.  In your
case, the warning tells you that

  gnus-summary-select-article-buffer

already has an advice on it.  Your new defadvice deactivates the old
piece of advice and activates the new one.

Bye,
Tassilo