From: Eric Schulte <eric.schulte@gmx.com>
To: Ilya Shlyakhter <ilya_shl@alum.mit.edu>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fixed compiler warnings including one small bug in ob-lilypond
Date: Fri, 16 Mar 2012 10:48:14 -0400 [thread overview]
Message-ID: <8739987g67.fsf@gmx.com> (raw)
In-Reply-To: jjvj5j$dhc$1@dough.gmane.org
Applied, Thanks!
Ilya Shlyakhter <ilya_shl@alum.mit.edu> writes:
> Re-sending the patch as a correct attachment type.
> One of the warnings indicated an actual (small) bug.
>
> From d0579b6e104b82ec7d3255086384ff8dee0d4e0e Mon Sep 17 00:00:00 2001
> From: Ilya Shlyakhter <ilya_shl@alum.mit.edu>
> Date: Fri, 16 Mar 2012 01:52:03 -0400
> Subject: [PATCH] Fixed compiler warnings, including one small bug in ob-lilypond
>
> * lisp/ob-lilypond.el (ly-compile-lilyfile): Fixed misplaced comma in a
> quoting expression.
>
> * lisp/org-pcomplete.el: added missing defvar definitions for org vars
>
> * lisp/org-src.el: added declare-function line for org-babel-tangle
>
> * lisp/ob.el (org-scan-tags): protected the variable tags-list with a let
> (other) added missing defvar declarations.
>
> TINYCHANGE
> ---
> lisp/ob-lilypond.el | 2 +-
> lisp/org-pcomplete.el | 5 +++++
> lisp/org-src.el | 2 ++
> lisp/org.el | 9 +++++++--
> 4 files changed, 15 insertions(+), 3 deletions(-)
>
> diff --git a/lisp/ob-lilypond.el b/lisp/ob-lilypond.el
> index a008b2d..0e9b0c6 100644
> --- a/lisp/ob-lilypond.el
> +++ b/lisp/ob-lilypond.el
> @@ -223,7 +223,7 @@ FILE-NAME is full path to lilypond (.ly) file"
> (arg-11 file-name))
> (if test
> `(,arg-1 ,arg-2 ,arg-3 ,arg-4 ,arg-5 ,arg-6
> - ,arg-7 ,arg-8 ,arg-9 ,arg-10, arg-11)
> + ,arg-7 ,arg-8 ,arg-9 ,arg-10 ,arg-11)
> (call-process
> arg-1 arg-2 arg-3 arg-4 arg-5 arg-6
> arg-7 arg-8 arg-9 arg-10 arg-11))))
> diff --git a/lisp/org-pcomplete.el b/lisp/org-pcomplete.el
> index c475bcc..7a4dc0d 100644
> --- a/lisp/org-pcomplete.el
> +++ b/lisp/org-pcomplete.el
> @@ -50,6 +50,9 @@
> :tag "Org"
> :group 'org)
>
> +(defvar org-drawer-regexp)
> +(defvar org-property-re)
> +
> (defun org-thing-at-point ()
> "Examine the thing at point and let the caller know what it is.
> The return value is a string naming the thing at point."
> @@ -247,6 +250,8 @@ This needs more work, to handle headings with lots of spaces in them."
> lst))
> (substring pcomplete-stub 1)))
>
> +(defvar org-drawers)
> +
> (defun pcomplete/org-mode/drawer ()
> "Complete a drawer name."
> (let ((spc (save-excursion
> diff --git a/lisp/org-src.el b/lisp/org-src.el
> index 88217cd..cc5a6ca 100644
> --- a/lisp/org-src.el
> +++ b/lisp/org-src.el
> @@ -686,6 +686,8 @@ the language, a switch telling if the content should be in a single line."
> (interactive)
> (org-src-in-org-buffer (save-buffer)))
>
> +(declare-function org-babel-tangle "ob-tangle" (&optional only-this-block target-file lang))
> +
> (defun org-src-tangle (arg)
> "Tangle the parent buffer."
> (interactive)
> diff --git a/lisp/org.el b/lisp/org.el
> index 951f692..7f8eddb 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -76,6 +76,7 @@
> (require 'gnus-sum))
>
> (require 'calendar)
> +(require 'format-spec)
>
> ;; Emacs 22 calendar compatibility: Make sure the new variables are available
> (when (fboundp 'defvaralias)
> @@ -4930,6 +4931,8 @@ sure that we are at the beginning of the line.")
> "Matches an headline, putting stars and text into groups.
> Stars are put in group 1 and the trimmed body in group 2.")
>
> +(defvar bidi-paragraph-direction)
> +
> ;;;###autoload
> (define-derived-mode org-mode outline-mode "Org"
> "Outline-based notes management and organizer, alias
> @@ -12854,7 +12857,7 @@ headlines matching this string."
> (buffer-name (buffer-base-buffer)))))))
> (case-fold-search nil)
> (org-map-continue-from nil)
> - lspos tags
> + lspos tags tags-list
> (tags-alist (list (cons 0 org-file-tags)))
> (llast 0) rtn rtn1 level category i txt
> todo marker entry priority)
> @@ -14986,6 +14989,7 @@ So these are more for recording a certain time/date."
> (defvar org-read-date-final-answer nil)
> (defvar org-read-date-analyze-futurep nil)
> (defvar org-read-date-analyze-forced-year nil)
> +(defvar org-read-date-inactive)
>
> (defun org-read-date (&optional with-time to-time from-string prompt
> default-time default-input inactive)
> @@ -15185,7 +15189,6 @@ user."
> (defvar def)
> (defvar defdecode)
> (defvar with-time)
> -(defvar org-read-date-inactive)
> (defun org-read-date-display ()
> "Display the current date prompt interpretation in the minibuffer."
> (when org-read-date-display-live
> @@ -17008,6 +17011,8 @@ Some of the options can be changed using the variable
> (error "Unknown conversion type %s for latex fragments"
> processing-type)))))))))
>
> +(declare-function format-spec "format-spec" (format specification))
> +
> (defun org-create-math-formula (latex-frag &optional mathml-file)
> "Convert LATEX-FRAG to MathML and store it in MATHML-FILE.
> Use `org-latex-to-mathml-convert-command'. If the conversion is
--
Eric Schulte
http://cs.unm.edu/~eschulte/
next prev parent reply other threads:[~2012-03-16 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 5:55 [PATCH] Fixed compiler warnings including typo in ob-lilypond Ilya Shlyakhter
2012-03-16 14:36 ` [PATCH] Fixed compiler warnings including one small bug " Ilya Shlyakhter
2012-03-16 14:48 ` Eric Schulte [this message]
2012-03-16 18:46 ` Achim Gratz
2012-03-20 12:16 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739987g67.fsf@gmx.com \
--to=eric.schulte@gmx.com \
--cc=emacs-orgmode@gnu.org \
--cc=ilya_shl@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.