From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 11328@debbugs.gnu.org
Subject: bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code
Date: Thu, 26 Apr 2012 20:38:35 +0200 [thread overview]
Message-ID: <87397q8hh8.fsf@gmail.com> (raw)
In-Reply-To: <8029A2B122324A82AEAC6FC2A742F198@us.oracle.com> (Drew Adams's message of "Thu, 26 Apr 2012 08:35:49 -0700")
"Drew Adams" <drew.adams@oracle.com> writes:
> As I explained, in the particular case of NAME-CONSTRUCTOR and TARGET the caller
> does not in fact ever need (make use of) the _variable_ TARGET. All it needs is
> its value, i.e., the value at the time and place that the lambda is constructed,
> in `d-do-create-files'.
>
> So there is no need to include the _variable_ itself in the lambda form. It is
> sufficient to use its value there. That is clearer to read and is cleaner code.
Yes that is what i wanted to explain.
> And there is no need either to pass TARGET as an additional argument to
> `d-create-files'.
Of course there is no need to do this, it would change nothing, just
make the code clearer to use and read.
What can be done also is leave `dired-create-files' as it is and modify
`dired-do-create-files' to have a generic function usable anywhere
(actually it is usable only in dired) and easy to use; It is what I do here.
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
next prev parent reply other threads:[~2012-04-26 18:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 17:37 bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code Drew Adams
2012-04-24 17:49 ` Drew Adams
2012-04-24 18:22 ` Drew Adams
2012-04-25 13:40 ` Nix
2012-04-25 16:26 ` Drew Adams
2012-04-25 18:42 ` Thierry Volpiatto
2012-04-25 21:51 ` Drew Adams
2012-04-26 5:48 ` Thierry Volpiatto
2012-04-26 14:09 ` Drew Adams
2012-04-26 15:35 ` Drew Adams
2012-04-26 18:38 ` Thierry Volpiatto [this message]
2012-04-24 18:54 ` Stefan Monnier
2014-02-09 4:32 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87397q8hh8.fsf@gmail.com \
--to=thierry.volpiatto@gmail.com \
--cc=11328@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.