From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: coccinelle patch suggestion Date: Mon, 02 Jul 2012 13:05:31 -0600 Message-ID: <87395ax9tw.fsf@fleche.redhat.com> References: <4FEC506D.90408@yandex.ru> <87obo22hz8.fsf@fleche.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1341255942 13656 80.91.229.3 (2 Jul 2012 19:05:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 2 Jul 2012 19:05:42 +0000 (UTC) Cc: Dmitry Antipov , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 02 21:05:41 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SllwL-0008TX-9J for ged-emacs-devel@m.gmane.org; Mon, 02 Jul 2012 21:05:41 +0200 Original-Received: from localhost ([::1]:34101 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SllwK-0001R0-7n for ged-emacs-devel@m.gmane.org; Mon, 02 Jul 2012 15:05:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SllwH-0001QV-PS for emacs-devel@gnu.org; Mon, 02 Jul 2012 15:05:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SllwG-0003jo-0g for emacs-devel@gnu.org; Mon, 02 Jul 2012 15:05:37 -0400 Original-Received: from mx1.redhat.com ([209.132.183.28]:39169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SllwF-0003jU-Oy for emacs-devel@gnu.org; Mon, 02 Jul 2012 15:05:35 -0400 Original-Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q62J5Y1D014086 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 2 Jul 2012 15:05:34 -0400 Original-Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q62J5Wsk022956 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 2 Jul 2012 15:05:33 -0400 X-Attribution: Tom In-Reply-To: (Stefan Monnier's message of "Mon, 02 Jul 2012 14:12:13 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151373 Archived-At: Tom> What do you think of the appended? Stefan> I think it's going in the right direction. I do wonder/worry about Stefan> handling dependencies: for the current globals.h, there's no real Stefan> problem since if the vars in it can be pretty much only missing or Stefan> extraneous but can't be incorrect (they *very* rarely change type), but Stefan> it's slightly less rare to change the type of a DEFUN'd function Stefan> (i.e. adding/removing arguments). I think dependencies should already work fine. gl-stamp is rebuilt when a source file changes: gl-stamp: $(libsrc)/make-docfile$(EXEEXT) $(GLOBAL_SOURCES) Then this is used to rebuild global.h if the contents change: globals.h: gl-stamp; @true Is there a particular scenario you are concerned with? I could give it a try. Tom