bug with timestamp fontification (bisected to b6b509b)

bug with timestamp fontification (bisected to b6b509b)

[Nicolas Richard]

This is bisected to b6b509b (which 467f7ff claims to fix, and indeed
does partially)

Reproduce by doing:
emacs -q -L /home/youngfrog/sources/org-mode/lisp/ -f org-mode --eval '(insert "<2012-02-27 Wed.>")'
=> timestamp is not fontified.

or instead
emacs -q -L /home/youngfrog/sources/org-mode/lisp/ -f org-mode --eval '(insert "Whatever\n<2012-02-27 Wed.>")'
=> timestamp is fontified but fontification is lost if you hit RET

I tried to patch but didn't succeed. The newline (or beginning of
buffer in first case, but that's probably unimportant ?) seems to be the
problem. Any idea on that ?

-- 
N.

Re: bug with timestamp fontification (bisected to b6b509b)

[Suvayu Ali]

On Wed, Feb 27, 2013 at 04:54:54PM +0100, Nicolas Richard wrote:
> 
> Reproduce by doing:
> emacs -q -L /home/youngfrog/sources/org-mode/lisp/ -f org-mode --eval '(insert "<2012-02-27 Wed.>")'
                                                                                              ^^^^^

Are you sure your timestamp has the correct syntax?  As far as I know
there should be no periods at the end of the day name.

BTW, how do you enter timestamps?  You can use C-c C-x . and C-c C-x !
for active and inactive timestamps.  This way you can avoid sysntax
errors conveniently.

Hope this helps,

-- 
Suvayu

Open source is the future. It sets us free.

Re: bug with timestamp fontification (bisected to b6b509b)

[Bastien]

Hi Nicolas,

"Nicolas Richard" <theonewiththeevillook@yahoo.fr> writes:

> This is bisected to b6b509b (which 467f7ff claims to fix, and indeed
> does partially)

I think I *completely* fixed this now... thanks for the heads up
and the easy recipe!

-- 
 Bastien

Re: bug with timestamp fontification (bisected to b6b509b)

[Nicolas Richard]

Suvayu Ali <fatkasuvayu+linux@gmail.com> writes:

> On Wed, Feb 27, 2013 at 04:54:54PM +0100, Nicolas Richard wrote:
>> emacs -q -L /home/youngfrog/sources/org-mode/lisp/ -f org-mode --eval '(insert "<2012-02-27 Wed.>")'
> 
> Are you sure your timestamp has the correct syntax?  As far as I know
> there should be no periods at the end of the day name.

Sometimes there is a period, sometimes not. When and when not : I never
figured that out (never really tried to, either).

> BTW, how do you enter timestamps?  You can use C-c C-x . and C-c C-x !

That's what I use (usually). [except that there is no C-x]

-- 
N.

Re: bug with timestamp fontification (bisected to b6b509b)

[Nicolas Richard]

Bastien <bzg@altern.org> writes:
> I think I *completely* fixed this now... thanks for the heads up
> and the easy recipe!

Thanks ; indeed dropping the change to the regexp seems the easiest (and
may avoid problems with code relying on that regexp out of the core).

May I suggest that you fix the commit just once more ? Part of the
previous fix was to increase "group number" everywhere, and that has to
be reverted. Here is a patch if you prefer :

From 53152a802afe85e856d571867a2c8a36457cf0cd Mon Sep 17 00:00:00 2001
From: Nicolas Richard <theonewiththeevillook@yahoo.fr>
Date: Wed, 27 Feb 2013 17:55:42 +0100
Subject: [PATCH] Fix b6b509b one more time.

---
 lisp/org.el | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index b88b49a..7cf7832 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -5830,15 +5830,15 @@ by a #."
   (if (and (re-search-forward org-tsr-regexp-both limit t)
 	   (not (equal (char-before (match-beginning 0)) 91)))
       (progn
-	(org-remove-flyspell-overlays-in (match-beginning 1) (match-end 1))
-	(add-text-properties (match-beginning 1) (match-end 1)
+	(org-remove-flyspell-overlays-in (match-beginning 0) (match-end 0))
+	(add-text-properties (match-beginning 0) (match-end 0)
 			     (list 'mouse-face 'highlight
 				   'keymap org-mouse-map))
-	(org-rear-nonsticky-at (match-end 1))
+	(org-rear-nonsticky-at (match-end 0))
 	(when org-display-custom-times
-	  (if (match-end 4)
-	      (org-display-custom-time (match-beginning 4) (match-end 4)))
-	  (org-display-custom-time (match-beginning 2) (match-end 2)))
+	  (if (match-end 3)
+	      (org-display-custom-time (match-beginning 3) (match-end 3)))
+	  (org-display-custom-time (match-beginning 1) (match-end 1)))
 	t)))
 
 (defvar org-target-link-regexp nil
-- 
1.8.1.4

Re: bug with timestamp fontification (bisected to b6b509b)

[Bastien]

"Nicolas Richard" <theonewiththeevillook@yahoo.fr> writes:

> May I suggest that you fix the commit just once more ? Part of the
> previous fix was to increase "group number" everywhere, and that has to
> be reverted. Here is a patch if you prefer :

Applied... thanks! 

*Sigh*... I think I need to get unplugged for a while :)

-- 
 Bastien