From: Michael Heerdegen <michael_heerdegen@web.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 14926@debbugs.gnu.org
Subject: bug#14926: 24.3.50; Warning "`make-variable-buffer-local' should be called at toplevel"
Date: Thu, 15 Aug 2013 16:43:13 +0200 [thread overview]
Message-ID: <8738qb816m.fsf@web.de> (raw)
In-Reply-To: <jwvehar47yp.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 21 Jul 2013 22:59:11 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> > 1. The Elisp manual says nothing about this. Is this something new?
>
> No.
>
> > 2. What is wrong with code such as this at top level?
>
> Nothing. But most of the cases I bumped into (all of which have been
> fixed now, AFAIK) were cases where the author had confused
> make-local-variable and make-variable-buffer-local.
Maybe
"Warning: `make-variable-buffer-local' not called at toplevel"
would have the same learning experience, without saying "should be...",
which is wrong and confusing to people who know what they're doing.
Michael.
next prev parent reply other threads:[~2013-08-15 14:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 21:11 bug#14926: 24.3.50; Warning "`make-variable-buffer-local' should be called at toplevel" Drew Adams
2013-07-22 2:59 ` Stefan Monnier
2013-07-22 4:31 ` Drew Adams
2013-08-15 14:43 ` Michael Heerdegen [this message]
2013-08-15 16:33 ` Stefan Monnier
2013-08-15 18:19 ` Michael Heerdegen
2013-08-16 6:54 ` Glenn Morris
2013-08-16 7:34 ` Drew Adams
2013-08-16 7:45 ` Juanma Barranquero
2013-08-16 11:09 ` Michael Heerdegen
2013-08-16 14:07 ` Drew Adams
2013-08-16 21:23 ` Michael Heerdegen
2013-08-16 22:14 ` Drew Adams
2013-08-16 16:25 ` Stefan Monnier
2013-08-16 16:31 ` Juanma Barranquero
2013-08-16 17:58 ` Drew Adams
2013-08-16 18:01 ` Glenn Morris
2013-08-16 21:26 ` Michael Heerdegen
2013-08-16 21:40 ` Glenn Morris
2013-08-16 23:02 ` Michael Heerdegen
2014-02-08 5:28 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738qb816m.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=14926@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.