From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Claudio Bley Newsgroups: gmane.emacs.devel Subject: Re: build fails with new MinGW wchar.h Date: Thu, 21 Nov 2013 08:36:23 +0100 Message-ID: <8738mq4360.wl%claudio.bley@gmail.com> References: <87d2lvv8mh.wl%claudio.bley@gmail.com> <837gc3ey7m.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1385019396 22007 80.91.229.3 (21 Nov 2013 07:36:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Nov 2013 07:36:36 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 21 08:36:43 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VjOob-0004HE-LB for ged-emacs-devel@m.gmane.org; Thu, 21 Nov 2013 08:36:41 +0100 Original-Received: from localhost ([::1]:58940 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjOoa-0008RJ-W1 for ged-emacs-devel@m.gmane.org; Thu, 21 Nov 2013 02:36:40 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjOoT-0008R5-Jj for emacs-devel@gnu.org; Thu, 21 Nov 2013 02:36:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjOoP-0007XZ-3g for emacs-devel@gnu.org; Thu, 21 Nov 2013 02:36:33 -0500 Original-Received: from mail-ea0-x229.google.com ([2a00:1450:4013:c01::229]:45077) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjOoK-0007Wx-2L; Thu, 21 Nov 2013 02:36:24 -0500 Original-Received: by mail-ea0-f169.google.com with SMTP id l9so4383633eaj.14 for ; Wed, 20 Nov 2013 23:36:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=date:message-id:from:to:cc:subject:in-reply-to:references :user-agent:mime-version:content-type; bh=n9MCpTcIP9oAJ0uXwJwPPBdSJXco9+5Ko2gFETQDAjs=; b=vz28U18RwZj6OzFbNihyOV78vNHhhIH6nZnlZqoIqhWcucWxjyMJEPgEg+CWUUn6ho /DeL/aGmAr43jLwhj8Yb1vohxpOuTYEQRFVog9Oitcn8s05KJJAPDkbm6+/2LkekUi4O 8cqlrNGqP6lElaGrgnp/HRgPAoq1gJpsk64gtSGdrc+ZAqccqgBFUIMzLqzjv5H+jp9x Q8+pU9FuP7sDp4mt2o489DxCx9H3/m27MixL5wP2YHVJJi/vDSCALrMpnU/SN72OV1Jc UNx2v1Jb0hQWEpsKVeIXy1dxQ40Pkg1Hx2raZsaei+gPqNqkTKuqUXI1AVfm1px80Ap9 Vo8A== X-Received: by 10.15.110.75 with SMTP id cg51mr1249584eeb.42.1385019383075; Wed, 20 Nov 2013 23:36:23 -0800 (PST) Original-Received: from CLAUDIO-PC.localdomain.de (178-24-125-95-dynip.superkabel.de. [178.24.125.95]) by mx.google.com with ESMTPSA id a45sm50241620eem.6.2013.11.20.23.36.21 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Nov 2013 23:36:22 -0800 (PST) In-Reply-To: <837gc3ey7m.fsf@gnu.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3.50 (i686-pc-mingw32) MULE/6.0 (HANACHIRUSATO) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165466 Archived-At: At Wed, 20 Nov 2013 20:15:41 +0200, Eli Zaretskii wrote: > > > diff --git a/nt/inc/sys/stat.h b/nt/inc/sys/stat.h > > index f1d8341..88352b1 100644 > > --- a/nt/inc/sys/stat.h > > +++ b/nt/inc/sys/stat.h > > @@ -23,6 +23,8 @@ along with GNU Emacs. If not, see . */ > > > > #ifdef __MINGW32__ > > # include <_mingw.h> > > +# define _STAT_DEFINED > > Why did you need this part? nt/inc/sys/stat.h already defines > _STAT_DEFINED, why do we need a second definition. I just did not realize that it already has that defined. > > +# define _WSTAT_DEFINED > > We cannot define this symbol without also declaring the structures > guarded by it in the MinGW headers. We should add them, and then > define _WSTAT_DEFINED. Why? Since those declarations are not used anyway, what's the point in defining them in the first place? Furthermore, this define actually does not guard declarations of any structures, but only guards declarations of the functions: _wstat _wstat32 _wstat64 _wstat32i64 _wstat64i32 IMO, since none of those functions is used in Emacs' code base, we're already set. / Claudio