From: Claudio Bley <claudio.bley@googlemail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: build fails with new MinGW wchar.h
Date: Thu, 21 Nov 2013 08:36:23 +0100 [thread overview]
Message-ID: <8738mq4360.wl%claudio.bley@gmail.com> (raw)
In-Reply-To: <837gc3ey7m.fsf@gnu.org>
At Wed, 20 Nov 2013 20:15:41 +0200,
Eli Zaretskii wrote:
>
> > diff --git a/nt/inc/sys/stat.h b/nt/inc/sys/stat.h
> > index f1d8341..88352b1 100644
> > --- a/nt/inc/sys/stat.h
> > +++ b/nt/inc/sys/stat.h
> > @@ -23,6 +23,8 @@ along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>. */
> >
> > #ifdef __MINGW32__
> > # include <_mingw.h>
> > +# define _STAT_DEFINED
>
> Why did you need this part? nt/inc/sys/stat.h already defines
> _STAT_DEFINED, why do we need a second definition.
I just did not realize that it already has that defined.
> > +# define _WSTAT_DEFINED
>
> We cannot define this symbol without also declaring the structures
> guarded by it in the MinGW headers. We should add them, and then
> define _WSTAT_DEFINED.
Why? Since those declarations are not used anyway, what's the point in
defining them in the first place?
Furthermore, this define actually does not guard declarations of any
structures, but only guards declarations of the functions:
_wstat
_wstat32
_wstat64
_wstat32i64
_wstat64i32
IMO, since none of those functions is used in Emacs' code base, we're
already set.
/ Claudio
next prev parent reply other threads:[~2013-11-21 7:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 7:24 build fails with new MinGW wchar.h Claudio Bley
2013-11-20 18:15 ` Eli Zaretskii
2013-11-21 7:36 ` Claudio Bley [this message]
2013-11-21 17:36 ` Eli Zaretskii
2014-01-11 14:50 ` Eli Zaretskii
2014-01-14 10:28 ` Claudio Bley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738mq4360.wl%claudio.bley@gmail.com \
--to=claudio.bley@googlemail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.