From: Thien-Thi Nguyen <ttn@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: [PATCH] * lisp/subr.el (string-suffix-p): New function.
Date: Fri, 22 Nov 2013 10:12:46 +0100 [thread overview]
Message-ID: <8738mo4x69.fsf@zigzag.favinet> (raw)
In-Reply-To: <CAM9Zgm3DbKiwhC95Vj+C4BnfU252hAcr1wH_5n952+c7gEGubw@mail.gmail.com> (Bozhidar Batsov's message of "Fri, 22 Nov 2013 09:06:10 +0200")
[-- Attachment #1: Type: text/plain, Size: 784 bytes --]
() Bozhidar Batsov <bozhidar@batsov.com>
() Fri, 22 Nov 2013 09:06:10 +0200
No comments == no objections? :-)
I think symmetry alone is insufficient motivation. Whether
or not that design guideline is appropriate here (for Emacs)
is another question.
Generally, you can make a better case for inclusion if you
find many places in the code base where the function can be
used. Another way to improve its prospects is to show new
(and cool) code that would not be possible w/o the function.
As i see it, no comments == no invitation.
--
Thien-Thi Nguyen
GPG key: 4C807502
(if you're human and you know it)
read my lisp: (responsep (questions 'technical)
(not (via 'mailing-list)))
=> nil
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2013-11-22 9:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 11:24 [PATCH] * lisp/subr.el (string-suffix-p): New function Bozhidar Batsov
2013-11-22 7:06 ` Bozhidar Batsov
2013-11-22 9:12 ` Thien-Thi Nguyen [this message]
2013-11-22 10:00 ` Bozhidar Batsov
2013-11-22 10:15 ` Lars Magne Ingebrigtsen
2013-11-22 10:41 ` Bozhidar Batsov
2013-11-22 14:07 ` Stefan Monnier
2013-11-22 14:27 ` Bozhidar Batsov
2013-11-23 1:44 ` Stefan Monnier
2013-11-23 6:05 ` Josh
2013-11-23 13:57 ` Stefan Monnier
2013-11-23 10:16 ` Stephen J. Turnbull
2013-11-23 17:03 ` Lars Magne Ingebrigtsen
2013-11-22 15:06 ` Jarek Czekalski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738mo4x69.fsf@zigzag.favinet \
--to=ttn@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.