all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andreas Politz <politza@hochschule-trier.de>
To: Tassilo Horn <tsdh@gnu.org>
Cc: 16090@debbugs.gnu.org
Subject: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark
Date: Tue, 10 Dec 2013 23:16:52 +0100	[thread overview]
Message-ID: <8738m0fj1n.fsf@hochschule-trier.de> (raw)
In-Reply-To: <87y53sjwqq.fsf@thinkpad.tsdh.org> (Tassilo Horn's message of "Tue, 10 Dec 2013 21:07:25 +0100")

Tassilo Horn <tsdh@gnu.org> writes:

> Andreas Politz <politza@hochschule-trier.de> writes:
>> and this
>>
>> (with-current-buffer (find-file-noselect "some.pdf")
>>   (doc-view-goto-page 2)
>>   (pop-to-buffer (current-buffer)))
>>
>> also displays the first page.
>
> No, if some.pdf hasn't been open yet, it'll show page 2.  [...]

>> [...] shouldn't it read the winprop page?
>
> That happens during the second time the function is called with a real
> window by making the overlay showing the image with that window's page
> visible.

I am using a non-temporary cache directory and this makes a difference.

If the document is not yet converted when opening it, it works as you
said.  But if it is, the code which would insert the image after the
conversion never runs and the winprops for the popped up window look
like this:

(#<window 24 on some.pdf>
          (info . #("Page 2 of 4.\n" 0 12 (face bold)))
          (page . 2)
          (overlay . #<overlay in no buffer>))

,with overlay properties (shortened)

(help-echo "Page 2 of 4."
 display "Welcome to DocView! ..."
 window t
 doc-view t)

Then the last sexp in doc-view-new-window-function switches to the first
page, without using the page property.

-ap






  reply	other threads:[~2013-12-10 22:16 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-08 16:54 bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark Andreas Politz
2013-12-09  9:13 ` Tassilo Horn
2013-12-09 12:33   ` Andreas Politz
2013-12-09 14:56     ` Tassilo Horn
2013-12-09 16:55   ` Glenn Morris
2013-12-10  7:28     ` Tassilo Horn
2013-12-10  2:51 ` Stefan Monnier
2013-12-10  7:53   ` Tassilo Horn
2013-12-10 10:02     ` Andreas Politz
2013-12-10 11:58       ` Andreas Politz
2013-12-10 16:56     ` Andreas Politz
2013-12-10 20:07       ` Tassilo Horn
2013-12-10 22:16         ` Andreas Politz [this message]
2013-12-11  4:43     ` Stefan Monnier
2013-12-11 19:08       ` Tassilo Horn
2013-12-20  8:00 ` Tassilo Horn
2013-12-20  8:28   ` Andreas Politz
2013-12-20 13:02     ` Tassilo Horn
2014-04-02 14:43       ` Stefan Monnier
2014-04-04 13:43         ` Tassilo Horn
2014-04-04 15:14           ` Stefan Monnier
2014-04-04 15:53             ` Tassilo Horn
2014-04-04 16:04               ` Glenn Morris
2014-04-04 17:44                 ` Tassilo Horn
2013-12-20 14:33   ` Stefan Monnier
2013-12-20 14:36     ` Tassilo Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738m0fj1n.fsf@hochschule-trier.de \
    --to=politza@hochschule-trier.de \
    --cc=16090@debbugs.gnu.org \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.