From: Bastien <bzg@gnu.org>
To: Glenn Morris <rgm@gnu.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r115918: package.el: various fixes.
Date: Wed, 08 Jan 2014 18:40:25 +0100 [thread overview]
Message-ID: <8738kyid86.fsf@bzg.ath.cx> (raw)
In-Reply-To: <xglhyqwgi3.fsf@fencepost.gnu.org> (Glenn Morris's message of "Wed, 08 Jan 2014 12:05:56 -0500")
Glenn Morris <rgm@gnu.org> writes:
>>> + (when (assq package package-alist)
>>> (or
>>> (let ((pkg-descs (cdr (assq package package-alist))))
>
> This is redundant (accesses same thing twice).
>
>>> (and pkg-descs
>>> (version-list-<= min-version
>>> (package-desc-version (car pkg-descs)))))
>>> ;; Also check built-in packages.
>>> - (package-built-in-p package min-version)))
>>> + (package-built-in-p package min-version))))
>
> It also seems to make the "Also check built-in packages." branch
> unreachable.
Yes, fixed, thanks.
--
Bastien
prev parent reply other threads:[~2014-01-08 17:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1W0rBI-0004nD-NV@vcs.savannah.gnu.org>
2014-01-08 14:16 ` [Emacs-diffs] trunk r115918: package.el: various fixes Stefan Monnier
2014-01-08 15:00 ` Bastien
2014-01-08 17:05 ` Glenn Morris
2014-01-08 17:40 ` Bastien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738kyid86.fsf@bzg.ath.cx \
--to=bzg@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.