From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: lee Newsgroups: gmane.emacs.help Subject: Re: replacing a function with another one Date: Sun, 09 Mar 2014 21:57:17 +0100 Organization: my virtual residence Message-ID: <8738ir161u.fsf@yun.yagibdah.de> References: <87vbvofsi6.fsf@yun.yagibdah.de> <87bnxgs4r9.fsf@web.de> <87lhwj1cfz.fsf@yun.yagibdah.de> <87zjkz6vd5.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1394398737 18919 80.91.229.3 (9 Mar 2014 20:58:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 9 Mar 2014 20:58:57 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Sun Mar 09 21:59:06 2014 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WMkoI-0000qU-MU for geh-help-gnu-emacs@m.gmane.org; Sun, 09 Mar 2014 21:59:02 +0100 Original-Received: from localhost ([::1]:45486 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMkoI-0008TC-DF for geh-help-gnu-emacs@m.gmane.org; Sun, 09 Mar 2014 16:59:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMkns-0008OF-CP for help-gnu-emacs@gnu.org; Sun, 09 Mar 2014 16:58:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WMknl-0008HY-Fm for help-gnu-emacs@gnu.org; Sun, 09 Mar 2014 16:58:36 -0400 Original-Received: from client-194-42-186-216.muenet.net ([194.42.186.216]:51265 helo=yun.yagibdah.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMknl-0008Ep-7i for help-gnu-emacs@gnu.org; Sun, 09 Mar 2014 16:58:29 -0400 Original-Received: from lee by yun.yagibdah.de with local (Exim 4.80.1) (envelope-from ) id 1WMknh-0000Xc-VH for help-gnu-emacs@gnu.org; Sun, 09 Mar 2014 21:58:25 +0100 In-Reply-To: <87zjkz6vd5.fsf@web.de> (Michael Heerdegen's message of "Sun, 09 Mar 2014 20:10:46 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Mail-Followup-To: help-gnu-emacs@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 194.42.186.216 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:96362 Archived-At: Michael Heerdegen writes: > lee writes: > >> Defadvice shines. I wonder who invented that ... > > The file header says it was Hans Chalupsky. > > Note that defadvice has now been obsoleted by a new implementation: > nadvice.el. You can do all of the stuff that defadvice can, but it has > cleaner and simpler syntax and semantics. If this is new to you, you > may want to start learning with the new mechanism. Hm, that=C2=B4s probably the reason why defadvice doesn=C2=B4t appear in the documentation. So I guess should use advice-add instead --- and I can=C2=B4t figure out how to get that to work. I need to access the argument passed to the function the advice is for, too. I tried to find examples, without success. What I have is: (defadvice hi-lock-set-file-patterns (after lsl-hi-lock-set-file-patterns-a= dvice activate) (setq hi-lock-interactive-patterns (ad-get-arg 0))) How would I do the same with add-advice (or whatever is appropriate)? > trouble. Critical are changes in the sources that change syntax or > semantic of the original function, so expect that some of your advices > may stop working in future Emacs releases. Yes, that=C2=B4s exactly what I=C2=B4m trying to avoid. There is no way to= detect when something changes in hi-lock.el in such a way that what I=C2=B4m doing doesn=C2=B4t work anymore, or is there? Suddenly finding out that what I= =C2=B4m trying to do doesn=C2=B4t work anymore won=C2=B4t be so great. Taking a copy of hi-lock-mode and modify it isn=C2=B4t a good solution, either. There may be changes to the mode which my own version wouldn=C2=B4t have. One change I=C2=B4m thinking about is keeping the highlighting-patterns in a separate buffer and applying them to several buffers. That way, you can have several files that all use the same highlighting-patterns which were generated on the fly, centralised for the whole project (or some files of it). That=C2=B4ll probably require quite a few modifications. --=20 Knowledge is volatile and fluid. Software is power.