From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#16971: 24.3.50; comment-beginning behaves differently in current newcomment.el, leads to error in comment-indent-new-line Date: Tue, 11 Mar 2014 06:18:41 +0200 Message-ID: <8738ipid0e.fsf@yandex.ru> References: <5eha75j2yl.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1394511553 9262 80.91.229.3 (11 Mar 2014 04:19:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 11 Mar 2014 04:19:13 +0000 (UTC) Cc: 16971@debbugs.gnu.org, Frank Ruben To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 11 05:19:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WNE9x-0004Hu-63 for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Mar 2014 05:19:21 +0100 Original-Received: from localhost ([::1]:52292 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNE9w-00041c-I2 for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Mar 2014 00:19:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNE9m-00041T-7m for bug-gnu-emacs@gnu.org; Tue, 11 Mar 2014 00:19:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNE9e-0002zF-Uf for bug-gnu-emacs@gnu.org; Tue, 11 Mar 2014 00:19:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNE9e-0002zB-RF for bug-gnu-emacs@gnu.org; Tue, 11 Mar 2014 00:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WNE9e-0007uv-HG for bug-gnu-emacs@gnu.org; Tue, 11 Mar 2014 00:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Mar 2014 04:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16971 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 16971-submit@debbugs.gnu.org id=B16971.139451153530418 (code B ref 16971); Tue, 11 Mar 2014 04:19:02 +0000 Original-Received: (at 16971) by debbugs.gnu.org; 11 Mar 2014 04:18:55 +0000 Original-Received: from localhost ([127.0.0.1]:60756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNE9W-0007uY-SM for submit@debbugs.gnu.org; Tue, 11 Mar 2014 00:18:55 -0400 Original-Received: from mail-ea0-f173.google.com ([209.85.215.173]:51817) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNE9U-0007uM-3F for 16971@debbugs.gnu.org; Tue, 11 Mar 2014 00:18:52 -0400 Original-Received: by mail-ea0-f173.google.com with SMTP id r15so4085310ead.4 for <16971@debbugs.gnu.org>; Mon, 10 Mar 2014 21:18:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=T0BNPlXE7a2GFsCOZTsPqXr9oD9ey54DI1eH0c8qf1w=; b=Tp8T/IANif153jhbjqZgrGGM0rKHcrJI86VwWuSHDhhe9GlaZF7f9ZYBK4d+Id33mJ qmyDFWWeVwfdGl9uclqrgrjsQLhggNP4fLmS2Ryx48Mzh65j70oDBUfwuJ+RtEpBEoKC DhCPO9/ncn8CAHDgB4aUtoY1az6UQxUn4mXdrGnHcjQHh7AxLeXRTZO9Z/Q0ndnrYk+r gB8YuD92Cm2napWhC2zE0mS6B0niZvQ9y459AnOUG3qlRIO4zO3J8Jy1A1UKIut95W2i 7Bre2FV6KAo5ko2xhJGljuepfInOKyR/9Mh3LBcuPhJexAYu1vKtmtxX4Mb3G6cDsEVh 7y+w== X-Received: by 10.15.31.72 with SMTP id x48mr45485eeu.107.1394511531095; Mon, 10 Mar 2014 21:18:51 -0700 (PDT) Original-Received: from axl (31-125-150.netrun.cytanet.com.cy. [31.153.125.150]) by mx.google.com with ESMTPSA id 43sm52673011eeh.13.2014.03.10.21.18.48 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 10 Mar 2014 21:18:50 -0700 (PDT) In-Reply-To: (Glenn Morris's message of "Mon, 10 Mar 2014 20:17:43 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86735 Archived-At: >> Anyway in *scratch* buffer, it was like (where '|' marks cursor position): >> >> 1) With current newcomment.el (December 2013): >> >> (foo ; bar |baz >> >> M-j => >> >> (foo ; bar >> baz Apparently, that's because comment-start-skip in emacs-lisp-mode doesn't match `; ', it needs a preceding character, so it matches e.g. ` ; '. One fix would be to change it from "\\(\\(^\\|[^\\\\\n]\\)\\(\\\\\\\\\\)*\\);+ *" to "\\(\\(\\=\\|^\\|[^\\\\\n]\\)\\(\\\\\\\\\\)*\\);+ *". (not sure if there'll be other consequences of this) Another - revert the revision 114486 and just make `comment-beginning' use `syntax-ppss' after finding prospective comment starter points with `comment-search-backward', to check if the state at (match-end 0) is "inside comment".