From: Michael Heerdegen <michael_heerdegen@web.de>
To: help-gnu-emacs@gnu.org
Subject: Re: replacing a function with another one
Date: Tue, 11 Mar 2014 01:03:10 +0100 [thread overview]
Message-ID: <8738ipd2kh.fsf@web.de> (raw)
In-Reply-To: 87pplugjh6.fsf@yun.yagibdah.de
lee <lee@yun.yagibdah.de> writes:
> > (advice-add
> > 'hi-lock-write-interactive-patterns :around
> > ;; also include `hi-lock-file-patterns'
> > (lambda (f &rest args)
> What does (f &rest args) do or mean?
From the doc of `add-function', this is how :around advices FUNCTION are
called:
(lambda (&rest r) (apply FUNCTION OLDFUN r))
Note that the advice FUNCTION will be called with an additional (the
first) argument, which will be bound to the original function when the
advice is called. This way, you have direct access to the original
function through that binding in your advice, and you can call it with
funcall or apply. This "mechanism" is the replacement for the old
ad-do-it.
In my example, FUNCTION is (lambda (f &rest args) ...), which means that
f will be bound to OLDFUN, i.e. the original definition of
`hi-lock-write-interactive-patterns', and args will be bound to r, which
will be the list of arguments with which
`hi-lock-write-interactive-patterns' gets called.
> > (apply f args)))
>
> f args?
>
> hi-lock-write-interactive-patterns doesn´t have any arguments.
So, the function will always be called without arguments, which means
that args will be bound to the empty list - no problem.
So why did I write it that way? Because it works with any argument
list. Instead of specifying the original argument list in the advice,
I just use &rest args and apply the original function to args when I
don't need to know the value of any argument.
Of course you can also write
(advice-add
'hi-lock-write-interactive-patterns :around
(lambda (f)
(let ((hi-lock-interactive-patterns
(append hi-lock-interactive-patterns
hi-lock-file-patterns))))
(funcall f)))
But if some day `hi-lock-write-interactive-patterns' might become an
optional argument, this advice would raise an wrong number of arguments
error.
> [1]: Another question:
>
> To get patterns from a separate file, I´m using find-file. This is
> probably not very efficient: I suspect that the file is actually loaded
> every time, with all what that implies.
No, Emacs doesn't do such things. If the file is already found in a
buffer, this buffer will just be selected when you `find-file' the same
file again.
If you want to try this approach, you can use `find-file-noselect',
which returns the file's buffer (without selecting it) and assign it to
some variable foo. Later, you can always just use
(with-current-buffer foo ...).
Regards,
Michael.
next prev parent reply other threads:[~2014-03-11 0:03 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-08 19:43 replacing a function with another one lee
2014-03-08 19:54 ` Eli Zaretskii
2014-03-09 1:17 ` lee
2014-03-08 22:30 ` Michael Heerdegen
2014-03-09 17:58 ` lee
2014-03-09 19:10 ` Michael Heerdegen
2014-03-09 20:57 ` lee
2014-03-09 22:02 ` Michael Heerdegen
2014-03-10 0:53 ` lee
2014-03-10 2:18 ` Michael Heerdegen
2014-03-10 15:29 ` lee
2014-03-11 0:03 ` Michael Heerdegen [this message]
2014-03-11 13:34 ` lee
2014-03-11 23:40 ` Michael Heerdegen
2014-03-12 6:11 ` Michael Heerdegen
2014-03-12 7:07 ` Michael Heerdegen
2014-03-12 14:48 ` lee
2014-03-13 7:19 ` Michael Heerdegen
2014-03-15 19:51 ` lee
2014-03-17 12:00 ` Michael Heerdegen
2014-03-12 14:04 ` lee
2014-03-12 18:26 ` Stefan Monnier
2014-03-12 4:10 ` Michael Heerdegen
2014-03-10 12:44 ` Stefan Monnier
2014-03-10 23:35 ` lee
2014-03-11 0:41 ` Michael Heerdegen
2014-03-11 1:45 ` Michael Heerdegen
2014-03-11 19:05 ` lee
2014-03-11 22:58 ` Michael Heerdegen
2014-03-12 15:11 ` lee
2014-03-12 18:15 ` Stefan Monnier
2014-03-12 21:43 ` lee
2014-03-13 7:22 ` Michael Heerdegen
2014-03-15 20:02 ` lee
2014-03-11 4:11 ` lee
2014-03-11 5:01 ` Michael Heerdegen
2014-03-11 14:25 ` lee
2014-03-11 23:51 ` Michael Heerdegen
2014-03-12 15:22 ` lee
2014-03-13 7:33 ` Michael Heerdegen
2014-03-13 12:29 ` Stefan Monnier
2014-03-15 20:05 ` lee
2014-03-16 17:20 ` Stefan
2014-03-11 6:51 ` Michael Heerdegen
2014-03-11 15:41 ` lee
2014-03-11 23:21 ` Michael Heerdegen
2014-03-12 17:33 ` lee
2014-03-12 19:34 ` Florian Beck
2014-03-12 19:51 ` Florian Beck
2014-03-13 7:54 ` Michael Heerdegen
2014-03-15 20:14 ` lee
2014-03-12 12:45 ` Stefan Monnier
2014-03-12 17:42 ` lee
2014-03-13 2:43 ` Jambunathan K
2014-03-15 20:17 ` How to propose an emacs patch (Re: replacing a function with another one) lee
2014-03-16 3:21 ` Jambunathan K
2014-03-17 4:35 ` lee
2014-03-10 13:45 ` replacing a function with another one lee
2014-03-10 23:31 ` Michael Heerdegen
2014-03-12 13:16 ` Jambunathan K
2014-03-12 13:18 ` Jambunathan K
2014-03-15 20:22 ` lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738ipd2kh.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.