bug#17345: 24.4.50; some into clauses in cl-loop badly font-locked

[Thierry Volpiatto <thierry.volpiatto@gmail.com>]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> in cl-loop "into" and following and even sometimes previous paren is
>> font-locked with font-lock-comment-face:
>
>> --8<---------------cut here---------------start------------->8---
>>           and collect (if (fboundp 'package-desc-full-name)
>>                           id
>>                         (cons (symbol-name (car id))
>>                               (package-version-join (cdr id)))) into delete-list
>>                                                               ^^^^^^^^^^^^^^^^^^
>>                                                               font-lock-comment-face
>> --8<---------------cut here---------------end--------------->8---
>
> That should be font-lock-warning-face,

Yes sorry.

> and it should come with a tooltip attempting the succinctly explain
> the "problem".

It does, "Hidden behind deeper element; Move to another line ?"

> It's just a style warning, that your indentation makes it look like "into
> delete-list" is an argument to `cons' rather than to the surrounding
> `cl-loop'.

Yes probably but the last paren before "into" should not be highlighted IMO.

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997