From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.help Subject: Re: de-dynamicizing some code Date: Thu, 20 Nov 2014 12:13:11 +0800 Message-ID: <87389ev7ag.fsf@ericabrahamsen.net> References: <87h9xuv8q4.fsf@ericabrahamsen.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1416456509 21144 80.91.229.3 (20 Nov 2014 04:08:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Nov 2014 04:08:29 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Thu Nov 20 05:08:21 2014 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XrJ2b-0002Kd-FY for geh-help-gnu-emacs@m.gmane.org; Thu, 20 Nov 2014 05:08:21 +0100 Original-Received: from localhost ([::1]:33450 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrJ2a-0000sB-Tx for geh-help-gnu-emacs@m.gmane.org; Wed, 19 Nov 2014 23:08:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrJ2L-0000rp-5I for help-gnu-emacs@gnu.org; Wed, 19 Nov 2014 23:08:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrJ2E-0003aJ-Ck for help-gnu-emacs@gnu.org; Wed, 19 Nov 2014 23:08:05 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:39436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrJ2E-0003aA-65 for help-gnu-emacs@gnu.org; Wed, 19 Nov 2014 23:07:58 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XrJ2B-0002D4-CO for help-gnu-emacs@gnu.org; Thu, 20 Nov 2014 05:07:55 +0100 Original-Received: from 111.197.160.62 ([111.197.160.62]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 20 Nov 2014 05:07:55 +0100 Original-Received: from eric by 111.197.160.62 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 20 Nov 2014 05:07:55 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 20 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 111.197.160.62 User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.4 (gnu/linux) Cancel-Lock: sha1:d4h2Lw7VfTF3JZRnALongqoz+So= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:101069 Archived-At: Stefan Monnier writes: >> I assume the proper solution is to replace this: >> (funcall formatfun record) >> with: >> (funcall formatfun record indent fmt) >> Is that correct? > > There are various solutions, but this one looks like a very good > option, indeed. > > The next best thing is to rename the variables to bbdb-fmt and > bbdb-indent (and to add "(defvar bbdb-indent) (defvar bbdb-fmt)" > somewhere at top-level (to tell the compiler that these vars should use > dynamic binding). Interesting -- thanks. I guess in this case the simpler solution is enough. E