From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.bugs Subject: bug#19324: 25.0.50; add-function and nil Date: Fri, 12 Dec 2014 08:44:11 +0800 Message-ID: <87388lvgro.fsf@gmail.com> References: <87vbllxw05.fsf@gmail.com> <87bnnbt342.fsf@gmail.com> <877fxyu9h1.fsf@gmail.com> <87egs6uljg.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1418345130 9293 80.91.229.3 (12 Dec 2014 00:45:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 12 Dec 2014 00:45:30 +0000 (UTC) Cc: 19324-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 12 01:45:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XzEMF-0003pt-AE for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Dec 2014 01:45:23 +0100 Original-Received: from localhost ([::1]:54849 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzEMC-00047C-PQ for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Dec 2014 19:45:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzEM2-000468-SX for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2014 19:45:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzELv-0004ba-9K for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2014 19:45:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzELv-0004b3-69 for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2014 19:45:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XzELu-0003rX-QW for bug-gnu-emacs@gnu.org; Thu, 11 Dec 2014 19:45:02 -0500 Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Dec 2014 00:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 19324 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 19324@debbugs.gnu.org, sdl.web@gmail.com, sdl.web@gmail.com Original-Received: via spool by 19324-done@debbugs.gnu.org id=D19324.141834506714775 (code D ref 19324); Fri, 12 Dec 2014 00:45:01 +0000 Original-Received: (at 19324-done) by debbugs.gnu.org; 12 Dec 2014 00:44:27 +0000 Original-Received: from localhost ([127.0.0.1]:43343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzELL-0003qE-41 for submit@debbugs.gnu.org; Thu, 11 Dec 2014 19:44:27 -0500 Original-Received: from mail-pd0-f182.google.com ([209.85.192.182]:56413) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzELI-0003pw-Si for 19324-done@debbugs.gnu.org; Thu, 11 Dec 2014 19:44:25 -0500 Original-Received: by mail-pd0-f182.google.com with SMTP id p10so6064937pdj.27 for <19324-done@debbugs.gnu.org>; Thu, 11 Dec 2014 16:44:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=hvVr3AZ335UP7xfJkdxolvHaZ/kecta47HAX9CnEPCo=; b=KGP0fS/oC8G0I0f+2nEoCNzBFBPObr9jesA6QgvKgMOVUj8OUSlHU0YckVEMTVEqSY PZ5sTfHBd8HtdJB014Zm8By16dRcjhnMvDlpeflsfbMXfbkOSF+WjhpdVjfkbBhbEY8+ q0D3v+S6dVtt4G65t7XrsglRhuLipiwgjpQ/VVRtVSDOKS/jKgE1KRj643GvdUtMi5i2 L08pfyj2ZOOsb2hKzxBd1fWdzWaP19U9xUIlJCaxydP2wFNmr2/biTmvEQBS+vo04suV yBewL+fcLEOTXTT0YIgJS/VR6cYirBGnevJpxIXqlQioxBBunZpZZeZ6j/lK0qah6PNd 6KLg== X-Received: by 10.69.20.74 with SMTP id ha10mr21925781pbd.122.1418345058867; Thu, 11 Dec 2014 16:44:18 -0800 (PST) Original-Received: from fortuna ([114.248.243.62]) by mx.google.com with ESMTPSA id a6sm2366293pbu.64.2014.12.11.16.44.15 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Dec 2014 16:44:18 -0800 (PST) Face: iVBORw0KGgoAAAANSUhEUgAAACkAAAApAQAAAACAGz1bAAABKElEQVQYlWNg3NIt5FDPUPt7 4+X79Qyucz5/ugik+L2PBgKpyphaIK921q23QDnG0NBQoMr/vaWl9f8ZLL78uPv5PwN7RETfzXoG jhmFz27XM0RXmpuY/WfY+fv0Mc56BvFybfXA/wwL5t/wF61n2PU59axXPcOVzbmSW/8zrNt1benC /ww70hqUU/4zKCtrT9jwn8FhwynbufUMendE2aLqGRpdX9al1zM8eh17lKeeQcTMrdD5P8P3j/YT Q/8zXHSb7p1Qz/C4OM2JuZ7hgtI7K6AjqsMnf8j4z8C6xG1tw3+GqpqvsVn/GTzmpD9j/8/wP/oZ S/l/Bka+QO/g/wy15ueeFQL9N1O8mPU/g+umV3t1gdT0/1bTgHLqYVeXAlWKpMWt+w8Az82C9nHf X0cAAAAASUVORK5CYII= In-Reply-To: (Stefan Monnier's message of "Thu, 11 Dec 2014 14:11:25 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (CentOS Linux 7 (Core)) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:97239 Archived-At: On 2014-12-11 14:11 -0500, Stefan Monnier wrote: > No I don't have a fix for this. > `add-function' is designed to work on places that only hold functions, > so any other value (such as nil) will create problems. > > IOW a variable that can hold "either nil or a function" is not something > that add-function supports. > > I guess we could treat nil as an alias for `ignore' in the "proxy > function", which would fix this particular issue. See patch below. > But I don't intend to handle all the cases in which a "nil function" can > show up. Many/most uses of `foo-function' actually give a special > meaning to nil which is different from `ignore'. > So I'm not sure we should cater to this particular case. Thanks, Stefan, for the explanation. In that case maybe the workaround isn't needed because we still cannot tell if ORIG is missing. I consider the bug closed. Leo