From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#19566: (unload-feature 'misearch) breaks isearch Date: Sun, 11 Jan 2015 22:44:15 +0200 Organization: LINKOV.NET Message-ID: <87387hvyy7.fsf@mail.linkov.net> References: <87y4p9y2cq.fsf@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1421010207 25013 80.91.229.3 (11 Jan 2015 21:03:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 11 Jan 2015 21:03:27 +0000 (UTC) Cc: 19566@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 11 22:03:21 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YAPfL-0004iw-HJ for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Jan 2015 22:03:19 +0100 Original-Received: from localhost ([::1]:59362 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAPfK-0003dI-N7 for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Jan 2015 16:03:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAPfB-0003TB-PT for bug-gnu-emacs@gnu.org; Sun, 11 Jan 2015 16:03:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YAPf5-0002n9-I8 for bug-gnu-emacs@gnu.org; Sun, 11 Jan 2015 16:03:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAPf5-0002n5-EZ for bug-gnu-emacs@gnu.org; Sun, 11 Jan 2015 16:03:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YAPf5-00071A-6K for bug-gnu-emacs@gnu.org; Sun, 11 Jan 2015 16:03:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Jan 2015 21:03:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19566 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19566-submit@debbugs.gnu.org id=B19566.142101014726883 (code B ref 19566); Sun, 11 Jan 2015 21:03:03 +0000 Original-Received: (at 19566) by debbugs.gnu.org; 11 Jan 2015 21:02:27 +0000 Original-Received: from localhost ([127.0.0.1]:42906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAPeU-0006zW-Lb for submit@debbugs.gnu.org; Sun, 11 Jan 2015 16:02:26 -0500 Original-Received: from ps18281.dreamhost.com ([69.163.222.226]:48970 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YAPeT-0006zM-1C for 19566@debbugs.gnu.org; Sun, 11 Jan 2015 16:02:25 -0500 Original-Received: from localhost.linkov.net (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 23C8331601D70B; Sun, 11 Jan 2015 13:02:22 -0800 (PST) In-Reply-To: <87y4p9y2cq.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sun, 11 Jan 2015 11:37:57 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98234 Archived-At: > Using unload-feature to unload misearch.el also undefines the > autoloaded variables, which breaks isearch.el as it still uses > them. > > Please thus consider the patch MIMEd. > > * lisp/misearch.el (multi-isearch-unload-function): New function > to retain definitions of autoloaded variables when unloading. > (misearch-unload-function): New alias. Even though I see no way to reproduce the test case which breaks isearch.el (after unloading, isearch.el just re-loads misearch.el again), I agree that we definitely should correctly unload them.