From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#19481: package.el: support .tar archives featuring a pax_global_header entry Date: Sat, 31 Jan 2015 11:05:48 +0000 Message-ID: <87386ri50z.fsf_-_@violet.siamics.net> References: <871tne5qsd.fsf@violet.siamics.net> <83bnmibbla.fsf@gnu.org> <87wq5649qu.fsf_-_@violet.siamics.net> <87386ulj7a.fsf@violet.siamics.net> <83zj8zjq97.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1422702438 20646 80.91.229.3 (31 Jan 2015 11:07:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 31 Jan 2015 11:07:18 +0000 (UTC) To: 19481@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 31 12:07:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YHVtQ-0001lz-RN for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Jan 2015 12:07:12 +0100 Original-Received: from localhost ([::1]:40248 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHVtQ-0005Pv-1k for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Jan 2015 06:07:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHVtM-0005Po-Dm for bug-gnu-emacs@gnu.org; Sat, 31 Jan 2015 06:07:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YHVtJ-0002Il-6m for bug-gnu-emacs@gnu.org; Sat, 31 Jan 2015 06:07:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHVtH-0002H8-3l for bug-gnu-emacs@gnu.org; Sat, 31 Jan 2015 06:07:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YHVtG-0002Gc-96 for bug-gnu-emacs@gnu.org; Sat, 31 Jan 2015 06:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Jan 2015 11:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19481 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19481-submit@debbugs.gnu.org id=B19481.14227023648641 (code B ref 19481); Sat, 31 Jan 2015 11:07:02 +0000 Original-Received: (at 19481) by debbugs.gnu.org; 31 Jan 2015 11:06:04 +0000 Original-Received: from localhost ([127.0.0.1]:58464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHVsJ-0002FI-7x for submit@debbugs.gnu.org; Sat, 31 Jan 2015 06:06:03 -0500 Original-Received: from fely.am-1.org ([78.47.74.50]:41477) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHVsG-0002Er-83 for 19481@debbugs.gnu.org; Sat, 31 Jan 2015 06:06:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=HxSdMg/dD08GUC5adjzXJmUuUPTkFIGirBrXOuy2ecY=; b=b4v4ZnsgiHPHY4c2ZwBvwm3csuwwqm2mnfq2vUR4vzDarUGFDHU1Zuz8FZ8qbX+mQBK78CiZBq1LGo58WIEnTfRKxi08OkctR50yNn+APhw58qymD7zFUNdgi4lqr113CC0OZfJpgOkHiptfSxCsogQuTpY+PKvd+FeyTYJV2IY=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YHVsD-0002cf-7T for 19481@debbugs.gnu.org; Sat, 31 Jan 2015 11:05:57 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YHVs5-0004Es-RY for 19481@debbugs.gnu.org; Sat, 31 Jan 2015 18:05:49 +0700 Mail-Followup-To: 19481@debbugs.gnu.org In-Reply-To: <83zj8zjq97.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 31 Jan 2015 10:41:56 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98928 Archived-At: >>>>> Eli Zaretskii writes: >>>>> From: Ivan Shmakov Date: Wed, 28 Jan 2015 20:54:33 +0000 >> Please consider the revised patch MIMEd. >> * lisp/tar-mode.el (tar-header-extractable-p): New function. >> (tar-untar-buffer): Use it; or use the value of the new optional >> argument instead. >> * lisp/emacs-lisp/package.el (package-untar-buffer): Use >> tar-header-extractable-p. >> (package-tar-file-info): Consider the second file name in the >> archive if the first one has no directory component. > Thanks. > Can we have a test suite for this file, Which of the two? (Or three, to count the .tar file produced by $ git archive.) > and in particular for these changes? I hope to come with a suitable addition for test/automated/package-test.el shortly. Or do you suggest adding a test suite for tar-mode as well? FTR, the two changes I suggest are not /inter/dependent, so I intend to push them as two separate commits. (And I wonder if eit makes sense to now file a separate Severity: wishlist bug report for tar-header-extractable-p, so to provide a somewhat extended background for the feature.) > Failing that, please describe how you tested these changes. I=E2=80=99ve tested these using my MW package, like: =E2=80=A2 C-x b *new-buffer* RET; =E2=80=A2 M-x cd RET ~/devel/mw-el-2015/ RET; =E2=80=A2 C-u M-! git archive --prefix=3Dmw-0.2/ --format=3Dtar HEAD 2> /dev/null RET; =E2=80=A2 M-x tar-mode RET; =E2=80=A2 M-x package-install-from-buffer RET. > Otherwise, I have no comments, and no objections to commit this, once > we are sure it doesn't break anything. ACK, thanks. --=20 FSF associate member #7257 np. La vita =E2=80=94 Roberto Ricioppo =E2=80= =A6 B6A0 230E 334A