From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: package.el dependencies Date: Mon, 02 Feb 2015 15:14:37 +0100 Message-ID: <87386os8mq.fsf@gmail.com> References: <87wq4dpqib.fsf@gmail.com> <87wq44su8v.fsf@gmail.com> <877fw3789y.fsf@gmail.com> <874mr4sbfa.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1422886527 14559 80.91.229.3 (2 Feb 2015 14:15:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Feb 2015 14:15:27 +0000 (UTC) Cc: Stefan Monnier , emacs-devel To: bruce.connor.am@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 02 15:15:14 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YIHmS-0002Pq-Lc for ged-emacs-devel@m.gmane.org; Mon, 02 Feb 2015 15:15:12 +0100 Original-Received: from localhost ([::1]:54914 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIHmR-00008m-Mr for ged-emacs-devel@m.gmane.org; Mon, 02 Feb 2015 09:15:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIHm5-00008c-Vj for emacs-devel@gnu.org; Mon, 02 Feb 2015 09:14:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIHm1-0003eD-V6 for emacs-devel@gnu.org; Mon, 02 Feb 2015 09:14:49 -0500 Original-Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:53855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIHm1-0003e7-OD for emacs-devel@gnu.org; Mon, 02 Feb 2015 09:14:45 -0500 Original-Received: by mail-wi0-f172.google.com with SMTP id h11so17063559wiw.5 for ; Mon, 02 Feb 2015 06:14:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; bh=90xk8H33ymcbrnol9Dra1QeZnaN9tMPYE9oXSqffHrk=; b=DTuTxIYHA8O4zWRNIJeiSlK+v5qcm7lmvxXw1vEBB6Nov7hgeOdfV6tMgClaHN4tGu jBRofFW12Tvkx7KZRtxoO9b9luuDsJtPrLsNeNnMGLpUAYRUfs0o84p8Uhf7AhtoEZOl 6IngnNXQmAiA7n+mGBzv9fj/qM5QC5lYiXiNLb2QGPnWDbg4AYav8ya8kJy9UT+cesFp KR/aoHNcsGABJfqNU4tbd2izt/j/51tYnlwABoQG224FgfTfNjM2hRVutfGxD6fsaypG 1Q4zNM9MsegfBnm491aHxOVbguaw9SR6ygDRkUBhTedoFdhHjuiIruUgvo49wPf/GKgx hCcA== X-Received: by 10.180.198.209 with SMTP id je17mr24548606wic.17.1422886485140; Mon, 02 Feb 2015 06:14:45 -0800 (PST) Original-Received: from dell-14z ([37.163.229.5]) by mx.google.com with ESMTPSA id vh8sm28068469wjc.12.2015.02.02.06.14.42 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 02 Feb 2015 06:14:44 -0800 (PST) In-reply-to: <874mr4sbfa.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182254 Archived-At: Thierry Volpiatto writes: > Artur Malabarba writes: > >> Done. > > We have now duplicates with package--get-deps: > > (package--get-deps 'jedi) > =>(epc auto-complete python-environment epc auto-complete > python-environment > concurrent ctable concurrent ctable deferred deferred > popup popup deferred deferred) > > As a workaround, you can use delete-dups, but this need to be > implemented differently IMO. Maybe like this: diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 9a29d63..2157174 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -1428,9 +1428,8 @@ The file can either be a tar file or an Emacs Lisp file." when (assq name package-alist) collect name)) (indirect-deps (unless (eq only 'direct) - (apply #'append - direct-deps - (mapcar #'package--get-deps direct-deps))))) + (cl-loop for p in direct-deps + append (package--get-deps p 'direct))))) (cl-case only (direct direct-deps) (separate (list direct-deps indirect-deps)) (package--get-deps 'jedi) => (epc auto-complete python-environment concurrent ctable popup deferred) -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997