Re: [Emacs-diffs] master f469024: Use delete-char instead of delete-backward-char.

[vibhavp@gmail.com]

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>>     * lisp/leim/quail/hangul.el
>>     * lisp/progmodes/cperl-mode.el: Use delete-char instead of
>>     delete-backward-char, fixes compilation warnings.
>
> The above doesn't use the right syntax.  The right syntax looks like
>
>   * <filename> (<functionname>): blabla.
>
> IOW you need to add the function names.
> Please re-read https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs
>
>> @@ -2588,7 +2588,7 @@ Will untabify if `cperl-electric-backspace-untabify' is non-nil."
>>  	  (delete-region (point) p))
>>        (if cperl-electric-backspace-untabify
>>  	  (backward-delete-char-untabify arg)
>> -	(delete-backward-char arg)))))
>> +	(delete-char (- arg))))))
>
> This doesn't look right: I think here we do want to run
> delete-backward-char since this is part of a command which basically
> extends the normal binding of DEL which is delete-backward-char.
> Maybe we should call it interactively, tho.
>
>
>         Stefan

Attached patch. Does this look good?

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix.patch --]
[-- Type: text/x-diff, Size: 1433 bytes --]

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 74a0988..af0a0ad 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2015-03-19  Vibhav Pant  <vibhavp@gmail.com>
+
+	* lisp/progmodes/cperl-mode.el (cperl-electric-backspace):
+	Call delete-backward-space interactively instead of delete-char.
+
 2015-03-19  Stefan Monnier  <monnier@iro.umontreal.ca>
 
 	* emacs-lisp/eieio.el (object-slots): Return slot names as before
@@ -60,8 +65,10 @@
 
 2015-03-19  Vibhav Pant  <vibhavp@gmail.com>
 
-	* lisp/leim/quail/hangul.el
-	* lisp/progmodes/cperl-mode.el: Use delete-char instead of
+	* lisp/leim/quail/hangul.el (hangul-delete-backward-char)
+	(hangul-to-hanja-conversion):
+	* lisp/progmodes/cperl-mode.el (cperl-electric-keyword)
+	(cperl-electric-backspace): Use delete-char instead of
 	delete-backward-char, fixes compilation warnings.
 
 2015-03-18  Michael Albinus  <michael.albinus@gmx.de>
diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el
index f207016..2acfc10 100644
--- a/lisp/progmodes/cperl-mode.el
+++ b/lisp/progmodes/cperl-mode.el
@@ -2588,7 +2588,7 @@ Will untabify if `cperl-electric-backspace-untabify' is non-nil."
 	  (delete-region (point) p))
       (if cperl-electric-backspace-untabify
 	  (backward-delete-char-untabify arg)
-	(delete-char (- arg))))))
+	(call-interactively 'delete-backward-char)))))
 
 (put 'cperl-electric-backspace 'delete-selection 'supersede)
 

[-- Attachment #3: Type: text/plain, Size: 34 bytes --]

-- 
Vibhav Pant
vibhavp@gmail.com