From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#21311: 25.0.50; non-defvared hooks are not declared special with lexical-binding Date: Fri, 21 Aug 2015 17:40:32 +0200 Message-ID: <8737zc645r.fsf@gnu.org> References: <87vbc8g8dn.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1440173245 21869 80.91.229.3 (21 Aug 2015 16:07:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Aug 2015 16:07:25 +0000 (UTC) Cc: 21311@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 21 18:07:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZSoqX-0008Ca-VU for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Aug 2015 18:07:14 +0200 Original-Received: from localhost ([::1]:42385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSoqW-0003cy-Re for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Aug 2015 12:07:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSoRG-0007LI-DD for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2015 11:41:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZSoRD-0004DD-5d for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2015 11:41:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZSoRC-0004CS-Te for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2015 11:41:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZSoRC-00032U-0i for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2015 11:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Aug 2015 15:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21311 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21311-submit@debbugs.gnu.org id=B21311.144017163911643 (code B ref 21311); Fri, 21 Aug 2015 15:41:01 +0000 Original-Received: (at 21311) by debbugs.gnu.org; 21 Aug 2015 15:40:39 +0000 Original-Received: from localhost ([127.0.0.1]:34651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZSoQp-00031j-2E for submit@debbugs.gnu.org; Fri, 21 Aug 2015 11:40:39 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:56528) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZSoQl-00031a-QS for 21311@debbugs.gnu.org; Fri, 21 Aug 2015 11:40:36 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 83D47207C7 for <21311@debbugs.gnu.org>; Fri, 21 Aug 2015 11:40:35 -0400 (EDT) Original-Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 21 Aug 2015 11:40:35 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=XcC6jcs0J1DkvzgdxVjA7ZM8Qm4=; b=djneQ NeZXmx29zdx8jlz0fA7a0NLrBDKH7J+O4tnHj8lJ/i5ZsAN55OCUm3NuzBecDzwE sMFuQpd13ypzCoc00uvSvltn6wwEL+8oTViuVT0WUrJSIBl4+ZZ5IpLTvekwUKgf qUeav1rU66InAucXRH8SglXJEF5TDmUYa7tKiM= X-Sasl-enc: 188IcXyK7ji8cYRWA4ApzhdWQhHOvkwoPVa1kUXVUBua 1440171635 Original-Received: from thinkpad-t440p (unknown [2.163.198.26]) by mail.messagingengine.com (Postfix) with ESMTPA id C9D606800DE; Fri, 21 Aug 2015 11:40:34 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Fri, 21 Aug 2015 09:48:53 -0400") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105668 Archived-At: Stefan Monnier writes: >> It seems that hooks that are not declared using defvar but come into >> being just because of a (add-hook 'my-hook ...) are not declared as >> special meaning you cannot let-bind them to change their value in the >> dynamic scope of the let. > > Yes. > >> The bug disappears as soon as I >> - don't use lexical-binding, or >> - defvar the hook (Fix #1 or #2) > > I think either of fix #1 or #2 are proper fixes and I think there's not > much more we can do about it. Allright. > Arguably, nowadays packages should defvar all their hooks. Ok, then I'll issue a bug report for magit. That's the package whose non-defvared hook I wanted to let-bind. Bye, Tassilo