From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Location of tests (again) (was Re: Makefile-help) Date: Sat, 07 Nov 2015 10:55:42 +0000 Message-ID: <8737wiyt75.fsf_-_@russet.org.uk> References: <87d1vpoees.fsf@russet.org.uk> <87r3k3igy1.fsf@russet.org.uk> <86io5ewbhg.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1446893773 12362 80.91.229.3 (7 Nov 2015 10:56:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 7 Nov 2015 10:56:13 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 07 11:56:03 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zv1AA-0005r6-U0 for ged-emacs-devel@m.gmane.org; Sat, 07 Nov 2015 11:56:03 +0100 Original-Received: from localhost ([::1]:43222 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zv1AA-0001nE-6n for ged-emacs-devel@m.gmane.org; Sat, 07 Nov 2015 05:56:02 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zv19x-0001n5-OF for emacs-devel@gnu.org; Sat, 07 Nov 2015 05:55:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zv19u-0007tn-I2 for emacs-devel@gnu.org; Sat, 07 Nov 2015 05:55:49 -0500 Original-Received: from cheviot12.ncl.ac.uk ([128.240.234.12]:53783) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zv19u-0007tX-C0 for emacs-devel@gnu.org; Sat, 07 Nov 2015 05:55:46 -0500 Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk) by cheviot12.ncl.ac.uk with esmtp (Exim 4.63) (envelope-from ) id 1Zv19q-0001ET-Ci; Sat, 07 Nov 2015 10:55:42 +0000 Original-Received: from cpc6-benw10-2-0-cust45.gate.cable.virginm.net ([92.238.179.46] helo=localhost) by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1Zv19q-0005wh-HD; Sat, 07 Nov 2015 10:55:42 +0000 In-Reply-To: <86io5ewbhg.fsf@stephe-leake.org> (Stephen Leake's message of "Sat, 7 Nov 2015 00:48:59 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.240.234.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193509 Archived-At: Stephen Leake writes: > phillip.lord@russet.org.uk (Phillip Lord) writes: > >> Phillip Lord writes: >> >>> Is there an organisation for tests that I am unaware off? Would there be >>> interest in a policy based on file name? >> >> >> I've started work on writing a script to move all the files (seems >> better than doing it manually as it's more checkable), and I've updated >> my specification based on comments; I'll push all of this to a scratch >> branch tomorrow. >> >> While doing this, I've realised that I'm going to need to update the >> Makefile (which assumes a flat directory structure for tests). >> >> My make expertise is quite limited. Would anyone be free to help me get >> this working. > > I'm fairly good with make, and have time to work on this. > > Let me know the scratch branch name. Actually, it turned out not to be so difficult. I didn't know about eval in make, but once I'd worked that out, the changes were quite minimal. It's on scratch/multi-level-test-makefile My solution is currently limited to a fixed number of subdirs (i.e it's not fully recursive), but then that isn't like to change quickly, if at all. I'd welcome feedback, though. The proposed directory layout is inside a file called emacs-tests.org at top level (obviously not where I intend to leave it). I've accepted most of the changes people suggested except for one. Some one suggested to but tests of C core ~test/automated/src~ which sounded good. But thinking about it, it probably makes more sense to leave this for C level testing framework. So now we have test/automated/lisp test/automated/lisp/emacs-lisp test/automated/lisp/progmodes (and so on....) test/automated/lisp/c (lisp tests for the C core) test/automated/lisp/legacy (ones which don't fit, to be fixed) test/automated/src (empty but reserved for C tests of C core) There's a shell-script embedded in emacs-tests.org to actually apply the move. As we are in feature freeze, I'd plan to do this immediately after the release branch is ready. Comments welcome. Phil