From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Please add comments to isearch.el Date: Mon, 14 Dec 2015 02:16:31 +0200 Organization: LINKOV.NET Message-ID: <8737v5ubog.fsf@mail.linkov.net> References: <83fuzoojcn.fsf@gnu.org> <83poyd8kta.fsf@gnu.org> <20151211121617.GA3351@acm.fritz.box> <83y4d16txk.fsf@gnu.org> <83lh916jpp.fsf@gnu.org> <871tasbnhh.fsf@mail.linkov.net> <83d1uc6sdq.fsf@gnu.org> <874mfntfgq.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1450053826 22216 80.91.229.3 (14 Dec 2015 00:43:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 14 Dec 2015 00:43:46 +0000 (UTC) Cc: Alan Mackenzie , Eli Zaretskii , emacs-devel To: Artur Malabarba Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 14 01:43:37 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a8HEm-0005tT-KY for ged-emacs-devel@m.gmane.org; Mon, 14 Dec 2015 01:43:36 +0100 Original-Received: from localhost ([::1]:57146 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8HEl-0008Sn-Vw for ged-emacs-devel@m.gmane.org; Sun, 13 Dec 2015 19:43:36 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8HEg-0008Rk-K8 for emacs-devel@gnu.org; Sun, 13 Dec 2015 19:43:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8HEf-0000ol-N8 for emacs-devel@gnu.org; Sun, 13 Dec 2015 19:43:30 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:47411 helo=homiemail-a18.g.dreamhost.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8HEd-0000oQ-Ts; Sun, 13 Dec 2015 19:43:28 -0500 Original-Received: from homiemail-a18.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTP id 2134325006B; Sun, 13 Dec 2015 16:43:27 -0800 (PST) Original-Received: from localhost.linkov.net (m83-180-31-224.cust.tele2.ee [83.180.31.224]) (Authenticated sender: jurta@jurta.org) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTPA id D5543250069; Sun, 13 Dec 2015 16:43:25 -0800 (PST) In-Reply-To: (Artur Malabarba's message of "Sun, 13 Dec 2015 01:01:22 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 69.163.253.7 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196228 Archived-At: > On 12 Dec 2015 11:27 pm, "Juri Linkov" wrote: >> 1. Rename =E2=80=98lax=E2=80=99 to =E2=80=98lax-boundary=E2=80=99 to d= istinguish between lax at the > word/symbol >> boundary and lax-whitespace to avoid confusion, so rename the >> arg =E2=80=98lax=E2=80=99 to =E2=80=98lax-boundary=E2=80=99 in all = regexp-producing functions, >> isearch--lax-regexp-function-p to >> isearch--lax-boundary-regexp-function-p, etc. > > +1 > >> 2. Try to find a better common naming scheme used for the >> regexp-producing functions word-search-regexp, isearch-symbol-regex= p, >> character-fold-to-regexp. > > I think the first two shouldn't even be in isearch.el. There's a ton of > stuff in isearch.el that's just generally useful in searches (nothing > specific to incremental search), and should be moved to some search.el > file. Yes, everything with the prefix =E2=80=98search-=E2=80=99 in isearch.el (as well as occur commands in replace.el) are here for historical reasons= . >> 3. Use well established terminology that shortens the prefixes >> of character-related functions to just char- to use char-fold. >> =E2=80=98C-h f char TAB=E2=80=99 or =E2=80=98C-h v char TAB=E2=80=99= shows the standard >> Emacs naming convention. >> >> 4. Use the upper-case standard name =E2=80=9CUnicode=E2=80=9D in the d= ocumentation. Ohh, and I'd add also search-default-regexp-mode -> search-default-regexp= -function that currently causes confusion due to its similarity with isearch-regexp= -function. > I don't see what these have to do with the readability of isearch el, b= ut > by all means, feel free to do these. Maybe better to wait for establishing of regular merges from emacs-25 to master, because I'm afraid that renaming character-fold.el to char-fold.e= l now might cause merge conflicts on the first such merge.