all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] scratch/follow e8937de: Replace GROUP argument in six window primitives by new functions.
Date: Wed, 16 Dec 2015 02:39:08 +0200	[thread overview]
Message-ID: <8737v3fbqj.fsf@mail.linkov.net> (raw)
In-Reply-To: <20151215131539.GA5018@acm.fritz.box> (Alan Mackenzie's message of "Tue, 15 Dec 2015 13:15:39 +0000")

> Any objections to me merging (or rebasing) this into the emacs-25
> branch?  I think it's ready.

Thanks, Alan.  I have only a small remark: the function name
‘recenter-group’ is too ambiguous.  Adding ‘window-group’
somewhere inside its name would help to narrow its scope, e.g.
‘window-group-recenter’, or ‘recenter-window-group’, or
‘recenter-in-window-group’ by analogy with ‘pos-visible-in-window-group-p’.

And one question: are the functions follow-window-start,
follow-set-window-start, etc. too specific to follow-mode,
or it would be possible to generalize and move them to window.el
leaving only ‘follow-all-followers’ as a follow-specific function?



  parent reply	other threads:[~2015-12-16  0:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20151214165252.26784.43201@vcs.savannah.gnu.org>
     [not found] ` <E1a8WMm-0006yi-Di@vcs.savannah.gnu.org>
2015-12-15  1:30   ` [Emacs-diffs] scratch/follow e8937de: Replace GROUP argument in six window primitives by new functions John Wiegley
2015-12-15 13:15     ` Alan Mackenzie
2015-12-15 15:22       ` [Emacs-diffs] scratch/follow e8937ed: " John Wiegley
2015-12-16  0:39       ` Juri Linkov [this message]
2015-12-17 22:14         ` [Emacs-diffs] scratch/follow e8937de: " Alan Mackenzie
2015-12-17 23:52           ` Juri Linkov
2015-12-18  0:43             ` [Emacs-diffs] scratch/follow e8937ed: " John Wiegley
2015-12-18 10:57               ` Alan Mackenzie
2015-12-20 13:05                 ` Alan Mackenzie
2015-12-22 19:19                 ` John Wiegley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737v3fbqj.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.