From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: org-pdfview-open doesn't work anymore
Date: Sat, 06 Feb 2016 17:41:23 +0100
Message-ID: <8737t5pz9o.fsf@nicolasgoaziou.fr>
References: <87a8nfzp44.fsf@free.fr>
	<CALn3zogTXXjwOJh2tEDgAb9p9zqNAM+oJVjDC3eBG-KuiQqPFg@mail.gmail.com>
	<CALn3zogu6B+Lb7CKU6Nd7ni9-gN4utrWnBt-Wgg83+GQWtieTw@mail.gmail.com>
	<8760y3qdfw.fsf@nicolasgoaziou.fr>
	<CALn3zogaqJXC_Osyx4VeT9Oxi5fUKeZtQH8wn4ibEp2QE+Pvkg@mail.gmail.com>
	<87si16pylj.fsf@nicolasgoaziou.fr>
	<CALn3zoh3y+gFW_fDrmNRtwJZfpP2srx6cxcVAU6KWRha_wdCeQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45667)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aS5tM-0000Q0-TI
	for emacs-orgmode@gnu.org; Sat, 06 Feb 2016 11:39:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aS5tJ-0005Hd-La
	for emacs-orgmode@gnu.org; Sat, 06 Feb 2016 11:39:24 -0500
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:60871)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aS5tJ-0005HE-Ex
	for emacs-orgmode@gnu.org; Sat, 06 Feb 2016 11:39:21 -0500
In-Reply-To: <CALn3zoh3y+gFW_fDrmNRtwJZfpP2srx6cxcVAU6KWRha_wdCeQ@mail.gmail.com>
	(Michael Brand's message of "Sat, 6 Feb 2016 09:08:37 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Michael Brand <michael.ch.brand@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>, Julien Cubizolles <j.cubizolles@free.fr>

Hello,

Michael Brand <michael.ch.brand@gmail.com> writes:

> I just notice that in our case at least in case of wrong-type-argument the
> `cmd' is missing, so I suggest
>
>     ((wrong-number-of-arguments wrong-type-argument invalid-function)
>      (user-error "Please see Org News for version 9.0 about \
> `org-file-apps'--Lisp error: The function %S leads to %S" cmd err))
>
> for the attached intermediate patch version. For the above example of
> (zerop nil) it would not only report "wrong-type-argument" and
> "numberp" together with "nil" but also "zerop" which in our case is
> the registered application, the source of the problem where the user
> needs to look.

IMO, notifying user that there's something rotten in the state of
`org-file-apps' is enough. There's no need to go into the gory details
of the problem.

Anyway, if you feel strongly about it, your patch looks good and you can
push it.

Thank you.


Regards,

-- 
Nicolas Goaziou