From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#22591: 25.0.50; [PATCH] imagemagick orientation EXIF tag is respected Date: Tue, 09 Feb 2016 14:02:49 +1100 Message-ID: <8737t2lh5y.fsf@gnus.org> References: <87a8nc2ksw.fsf@secretsauce.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1454987063 16000 80.91.229.3 (9 Feb 2016 03:04:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 9 Feb 2016 03:04:23 +0000 (UTC) Cc: 22591@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 09 04:04:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aSyb4-0002gd-9t for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Feb 2016 04:04:10 +0100 Original-Received: from localhost ([::1]:51202 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSyb3-0007kh-CS for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Feb 2016 22:04:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSyb0-0007kK-5D for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2016 22:04:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSyaw-0003UY-VF for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2016 22:04:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSyaw-0003UU-SJ for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2016 22:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aSyaw-0007mr-Gh for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2016 22:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Feb 2016 03:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22591 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22591-submit@debbugs.gnu.org id=B22591.145498699929883 (code B ref 22591); Tue, 09 Feb 2016 03:04:02 +0000 Original-Received: (at 22591) by debbugs.gnu.org; 9 Feb 2016 03:03:19 +0000 Original-Received: from localhost ([127.0.0.1]:60804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSyaE-0007lv-PS for submit@debbugs.gnu.org; Mon, 08 Feb 2016 22:03:18 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:40058) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSyaD-0007ln-0G for 22591@debbugs.gnu.org; Mon, 08 Feb 2016 22:03:17 -0500 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aSyZq-0006rp-4T; Tue, 09 Feb 2016 04:02:54 +0100 In-Reply-To: <87a8nc2ksw.fsf@secretsauce.net> (Dima Kogan's message of "Sun, 07 Feb 2016 14:54:39 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aSyZq-0006rp-4T MailScanner-NULL-Check: 1455591774.91119@wq0bwpUfP2Ynx/r61cG0yw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112777 Archived-At: Dima Kogan writes: > Hi. Here are two small patches to improve handling of images loaded with > the imagemagick backend. They are: > > 1. Accept integer :rotation parameters. Previously only floating-point > ones worked > > 2. If an EXIF orientation tag exists and no explicit :rotation exists, > use the orientation. This happens early in the processing, so all the > data (width, height, etc) that emacs sees applies to the rotated image. > > The motivation for this was that I was tired of seeing upside-down > photos in my mu4e mail. Looks good. I wonder whether this should go in the trunk, though? It's a new feature of sorts. But we could consider not showing images correctly rotated a bug... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no