bug#22451: 24.5; `customize-apropos-options': wrong message

[Lars Ingebrigtsen <larsi@gnus.org>]

Drew Adams <drew.adams@oracle.com> writes:

> emacs -Q
> M-x customize-apropos-options .* RET
>
> You see the message "Resetting customization items...", which is quite
> wrong.  Nothing is being reset.  Users will be confused and certainly
> hope/pray that that no option is actually being "reset".

Richard added those messages in 2005...  I'm not quite sure what the
logic is here, but there does seem to be something...  reset...  here...

   (message "Creating customization items ...done")
+  (message "Resetting customization items...")
   (unless (eq custom-buffer-style 'tree)
     (mapc 'custom-magic-reset custom-options))
+  (message "Resetting customization items...done")
   (message "Creating customization setup...")

Oh, it's just a redrawing thing:

----------
custom-magic-reset is a compiled Lisp function in ‘cus-edit.el’.

(custom-magic-reset WIDGET)

Redraw the :custom-magic property of WIDGET.
----------

In that case I agree that the message is misleading, and I think it
should just be removed.  That part doesn't seem to take that much time,
anyway.  Richard?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no